Improve error message when @BeanParam class has no fields #47592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Apr 29, 2025
| throw new DeploymentException(String.format("No annotations found on fields at '%s'. " | ||
| + "Annotations like `@QueryParam` should be used in fields, not in methods.", | ||
| beanParamClassInfo.name())); | ||
| long declaredMethodsCount = beanParamClassInfo.methods().stream() |
There was a problem hiding this comment.
You're counting methods but the message is about fields. I'm not sure I understand the logic here?
There was a problem hiding this comment.
Exactly. The current error message is misleading when there are no methods and fields so this tries to make things less misleading
This comment has been minimized.
This comment has been minimized.
FroMage
approved these changes
Apr 29, 2025
...cessor/src/main/java/org/jboss/resteasy/reactive/server/processor/ServerEndpointIndexer.java
Outdated
Show resolved
Hide resolved
|
I'll let you decide if you want my suggestion in or not :) |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Stéphane Épardaud <[email protected]> Closes: quarkusio#47545
gsmet
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #47545