OIDC refactoring: use accessors instead of deprecated fields marked for removal

[michalvavrik]

Requested here #47457, stop using deprecated fields marked for removal, use accessors instead.

[github-actions]

🎊 PR Preview a6fefd7 has been successfully built and deployed to https://quarkus-pr-main-47575-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[sberyozkin]

Hi Michal @michalvavrik

Looks perfect, thanks for simplifying and starting with this update only.

I have one minor suggestion, apologies for being annoying :-), can you please drop a OidcTenantConfig#isUserInfoRequired ? The shortcut in itself is neat an makes perfect sense, but it is not an actual ConnfigMapping property declaration.

You have put a lot of effort to clean things up with the legacy OidcTenantConfg, I'd just like to keep that ConfigMapping interface without any extra helpers, etc.
I agree it is a bit annoying to have .orElse(false) - but with this default method we don't know if it was set to anything by the user - which at some point might become relevant

[sberyozkin]

I'm not sure we want to keep Optional<Boolean> userInfoRequired(); and boolean isUserInfoRequired in one interface...

[michalvavrik]

I don't share your opinion on isUserInfoRequired method, I think it makes sense, but I'll drop it in few moment.s

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 629f3c6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 629f3c6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.