Skip to content

Gradle wrapper not created on windows #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2019
Merged

Gradle wrapper not created on windows #4753

merged 1 commit into from
Oct 22, 2019

Conversation

maxandersen
Copy link
Member

Fixes #4745

@maxandersen
Gradle wrapper not created on windows
0abfeaf 
Uses gradle.bat vs gradle on windows.
Changed Error to Warn when gradle not found.

Fixes quarkusio#4745
@maxandersen
Copy link
Member Author

difference in output is that instead of error about "Unable to install the Gradle wrapper (./gradlew) in project. See log for details." you now (if gradle is available) get something like:

[INFO] --- quarkus-maven-plugin:0.25.0:create (default-cli) @ standalone-pom ---
Creating a new project in C:\Users\max\test\.
Starting a Gradle Daemon (subsequent builds will be faster)

BUILD SUCCESSFUL in 34s
1 actionable task: 1 executed
<-------------> 0% WAITING                                                                                              > IDLE

AND gradlew.bat etc. available in the generated project.

@maxandersen maxandersen requested a review from geoand October 22, 2019 11:52
geoand
geoand approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it, but looks good!

@geoand geoand added this to the 0.27.0 milestone Oct 22, 2019
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 22, 2019
@geoand geoand merged commit 318c213 into quarkusio:master Oct 22, 2019
@gsmet gsmet removed the backport? label Oct 23, 2019
@gsmet gsmet modified the milestones: 0.27.0, 0.26.1 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoand geoand geoand approved these changes

Assignees

No one assigned

Labels

triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Milestone

0.26.1

Development

Successfully merging this pull request may close these issues.

gradle wrapper not created when creating projects on windows

3 participants

@maxandersen @geoand @gsmet