Skip to content

Qute: introduce equals operator for output expressions #47526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Qute: introduce equals operator for output expressions #47526

merged 1 commit into from
Apr 30, 2025

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 24, 2025

@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Apr 24, 2025
@mkouba mkouba mentioned this pull request Apr 24, 2025
Closed
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba force-pushed the issue-34315 branch 2 times, most recently from 77f300c to 535479d Compare April 28, 2025 08:04
@mkouba mkouba requested a review from ia3andy April 28, 2025 08:05
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 28, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
ia3andy
ia3andy reviewed Apr 28, 2025
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work as parameters too?

@mkouba
Copy link
Contributor Author

mkouba commented Apr 28, 2025

This should work as parameters too?

You mean as params of a virtual method call? Yes, that should work as well.

@ia3andy
Copy link
Contributor

ia3andy commented Apr 28, 2025

This should work as parameters too?

You mean as params of a virtual method call? Yes, that should work as well.

No test for this?

@mkouba
Copy link
Contributor Author

mkouba commented Apr 28, 2025

This should work as parameters too?

You mean as params of a virtual method call? Yes, that should work as well.

No test for this?

Nope, but of course I can add some ;-).

@mkouba
Copy link
Contributor Author

mkouba commented Apr 28, 2025

This should work as parameters too?

You mean as params of a virtual method call? Yes, that should work as well.

No test for this?

Nope, but of course I can add some ;-).

Done.

@mkouba mkouba requested a review from ia3andy April 28, 2025 15:43
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 28, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c0fe20d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 28, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c0fe20d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

✖ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

  • Too many recursions, message not returned for id [1667441767] - java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [1667441767]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)

@mkouba
Copy link
Contributor Author

mkouba commented Apr 29, 2025

@ia3andy I think that the DevUIGrpcSmokeTest#testTestService() is flaky and unrelated.

ia3andy
ia3andy approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba merged commit 74d7d69 into quarkusio:main Apr 30, 2025
60 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone Apr 30, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees

No one assigned

Labels

area/documentation area/qute The template engine kind/enhancement New feature or request triage/flaky-test

Projects

None yet

Milestone

3.23.0.CR1

Development

Successfully merging this pull request may close these issues.

Support ternary operator in expression

2 participants

@mkouba @ia3andy