Skip to content

Qute: fix build time validation and generated value resolver for getters #47497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Qute: fix build time validation and generated value resolver for getters #47497

merged 1 commit into from
Apr 23, 2025

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 23, 2025

  • the problem occurs when the getter syntax is mixed with "normal" syntax (Java record-style); e.g. Foo#image() and Foo#hasImage()

@mkouba
Qute: fix build time validation and generated value resolver for getters
8525233 
- the problem occurs when the getter syntax is mixed with "normal"
syntax (Java record-style); e.g. Foo#image() and Foo#hasImage()
@mkouba mkouba requested a review from ia3andy April 23, 2025 09:19
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Apr 23, 2025
@ia3andy
Copy link
Contributor

ia3andy commented Apr 23, 2025

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 23, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8525233.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

ia3andy
ia3andy approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba merged commit edb449b into quarkusio:main Apr 23, 2025
28 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone Apr 23, 2025
@gsmet gsmet modified the milestones: 3.23 - main, 3.22.1 Apr 29, 2025
@jmartisk jmartisk modified the milestones: 3.22.1, 3.20.2 Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees

No one assigned

Labels

area/qute The template engine refresh-issue-index

Projects

None yet

Milestone

3.20.2

Development

Successfully merging this pull request may close these issues.

4 participants

@mkouba @ia3andy @jmartisk @gsmet