Skip to content

Conversation

@holly-cummins
Copy link
Contributor

I spotted a case where I sometimes wrapped runtime exceptions unnecessarily, so I've fixed that. I've also fixed some typos in comments.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool, RuntimeException wrapping is annoying.

@holly-cummins
Copy link
Contributor Author

Oh cool, RuntimeException wrapping is annoying.

You mentioned the evils of wrapped exceptions the other week and I had a bit of anxiety because I was fairly sure I'd been guilty of it in the classloading rewrite. I had it on my todo to go through and search the patch for them, but before I could, one of my own wrapped exceptions popped up in a stack trace and served me right by annoying me. :)

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 22, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 02f0807.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 5f5e2bf into quarkusio:main Apr 22, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone Apr 22, 2025
@gsmet gsmet modified the milestones: 3.23 - main, 3.22.0 Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants