Tweaks for permission checkers for WebSockets Next

[rsvoboda]

Tweaks for permission checkers for WebSockets Next

Part of work on QUARKUS-5859 Support permission checkers for WebSockets Next

• PermissionChecker JavaDoc link
• Uni usage in PermissionChecker and WS endpoint, OnError with WebSocketConnection

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cb5bec7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

[michalvavrik]

This needs a review from @mkouba and @sberyozkin.

[michalvavrik]

Considering io.quarkus.websockets.next.test.security.HttpUpgradePermissionCheckerTest.Checker#canDoReadOnEndpoint doesn't check open, the check is happening on the upgrade, this shouldn't have any relation at all. But that's just FYI, I don't think there is anything wrong about the change.

[mkouba]

Hm, and what's the actual reason for this change?

[sberyozkin]

@rsvoboda Hi Rostislav, can you please reply here to Martin before we merge ? I'm assuming the plan is to increase the test coverage of different open response types

[rsvoboda]

Exactly, to cover different response type. I missed that, thanks for reminder @sberyozkin

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cb5bec7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[github-actions]

🙈 The PR is closed and the preview is expired.

[sberyozkin]

Thanks @rsvoboda @michalvavrik,
LGTM, perhaps we should copy those tests to keep testing non-Uni responses and add the ones returning Uni ?

[rsvoboda]

@sberyozkin, about Uni<Boolean> and Uni<String>, I tried to go a non-invasive way, not to drop coverage for non-Uni responses. They are still covered:

• hasPerm1 in PayloadPermissionCheckerTest returns a boolean, I changed just hasPerm2
• @OnOpen methods in PayloadPermissionCheckerTest return String
• Only @OnOpen method for AdminEndpoint in HttpUpgradePermissionCheckerTest returns Uni<String>

[sberyozkin]

Thanks @rsvoboda, great both Uni and non Uni variations are covered