Skip to content

Conversation

brunobat
Copy link
Contributor

This fixes the issue reported by this user in this comment: #47031 (comment)

Copy link

quarkus-bot bot commented Apr 21, 2025

/cc @radcortez (opentelemetry)

@brunobat brunobat changed the title Add Metrics and OTel Capabilities Add Metrics and Logs to OTel Capabilities Apr 21, 2025
@brunobat brunobat requested a review from alesj April 21, 2025 16:18

This comment has been minimized.

Copy link

github-actions bot commented Apr 21, 2025

🎊 PR Preview 8aa7c0b has been successfully built and deployed to https://quarkus-pr-main-47458-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Jul 7, 2025

@brunobat I rebased this PR, which I think has value. Just want to check if merging it will be in the way of some ongoing work or not?

This comment has been minimized.

This comment has been minimized.

@gsmet gsmet force-pushed the add-metrics-logs-otel-capabilities branch from efee067 to 68203cf Compare July 8, 2025 16:54
Copy link

quarkus-bot bot commented Jul 8, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 68203cf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jul 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 68203cf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-9","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-9","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/kafka-devservices

io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange - History

  • 1 expectation failed. Expected status code <200> but was <500>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/kafka-devservices

io.quarkus.it.kafka.continuoustesting.DevServicesDevModeTest.testDevModeServiceDoesNotRestartContainersOnCodeChange - History

  • 1 expectation failed. Expected status code <200> but was <500>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

@brunobat
Copy link
Contributor Author

brunobat commented Jul 9, 2025

Yes, At a conference right now. Will work on a bunch of stale PRs next week.

@gsmet gsmet merged commit fd74904 into quarkusio:main Jul 9, 2025
59 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jul 9, 2025
@gsmet
Copy link
Member

gsmet commented Jul 9, 2025

This one looks good so let's merge. One less for you to deal with :).

@brunobat
Copy link
Contributor Author

Thanks @gsmet

@gsmet gsmet removed this from the 3.25.0.CR1 milestone Jul 16, 2025
@gsmet gsmet added this to the 3.24.4 milestone Jul 16, 2025
@brunobat
Copy link
Contributor Author

brunobat commented Aug 5, 2025

@gsmet, we might need to backport due to QUARKUS-6463. Reported for 3.20.2.CR1.

@gsmet
Copy link
Member

gsmet commented Aug 5, 2025

OK, but it should have been the triage/backport-3.20 label. I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants