Skip to content

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 16, 2025

This also removed the old @io.quarkus.test.junit.mockito.InjectMock which means it is a breaking change


@Path("/unprocessable")
@RegisterRestClient(configKey = "w-fault-tolerance")
@RegisterRestClient(configKey = "w-fault-tolerance-int")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made in order to make the client have a config key that is not defined anywhere

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@Postremus Postremus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related, i stumbled upon this log message a few days back:

test-framework/junit5-mockito/src/main/java/io/quarkus/test/junit/mockito/internal/SetMockitoMockAsBeanMockCallback.java

This would also need to be adjusted when the old InjectMock annotation is gone.

@geoand
Copy link
Contributor Author

geoand commented Apr 16, 2025

Great point!

This was deprecated back in 3.2, so it's time to get
rid of it
Copy link

quarkus-bot bot commented Apr 16, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 80a1b71.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Integration Tests - JDK 17 Logs Raw logs 🔍
JVM Integration Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍
✔️ JVM Integration Tests - JDK 21 Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ JVM Integration Tests - JDK 17 Windows #

- Failing: integration-tests/oidc-wiremock-logout 

📦 integration-tests/oidc-wiremock-logout

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on project quarkus-integration-test-oidc-wiremock-logout:

See D:\a\quarkus\quarkus\integration-tests\oidc-wiremock-logout\target\surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

  • expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)

@gsmet gsmet merged commit 9af05b1 into quarkusio:main Apr 17, 2025
55 of 56 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.23 - main milestone Apr 17, 2025
@geoand geoand deleted the #47383 branch April 18, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mocked quarkus-rest-client complains about missing uri

3 participants