-
Notifications
You must be signed in to change notification settings - Fork 3k
Lift requirement of setting REST Client base URL when mocks are used #47401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| @Path("/unprocessable") | ||
| @RegisterRestClient(configKey = "w-fault-tolerance") | ||
| @RegisterRestClient(configKey = "w-fault-tolerance-int") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was made in order to make the client have a config key that is not defined anywhere
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related, i stumbled upon this log message a few days back:
test-framework/junit5-mockito/src/main/java/io/quarkus/test/junit/mockito/internal/SetMockitoMockAsBeanMockCallback.java
This would also need to be adjusted when the old InjectMock annotation is gone.
|
Great point! |
This was deprecated back in 3.2, so it's time to get rid of it
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Integration Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✖ | JVM Integration Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
| ✔️ | JVM Integration Tests - JDK 21 | Logs | Raw logs | 🔍 |
You can consult the Develocity build scans.
Failures
⚙️ JVM Integration Tests - JDK 17 Windows #
- Failing: integration-tests/oidc-wiremock-logout
📦 integration-tests/oidc-wiremock-logout
✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on project quarkus-integration-test-oidc-wiremock-logout:
See D:\a\quarkus\quarkus\integration-tests\oidc-wiremock-logout\target\surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/infinispan-cache/deployment
✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History
expected: "thread1" but was: "thread2"-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError:
expected: "thread1"
but was: "thread2"
at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)
This also removed the old
@io.quarkus.test.junit.mockito.InjectMockwhich means it is a breaking change