-
Notifications
You must be signed in to change notification settings - Fork 3k
Sort generated env by name in kubernetes extension #47370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome and easier than I initally thought.
Can we please add an integration test in integration-tests/kubernetes/quarkus-standard-way/
to ensure we won't run into regressions in the future?
Thanks! Yes, I will add an integration test. |
I've added an integration test. Do you think it is preferrable to sort the env vars only if |
@iocanel just making sure you did not miss my commit and comment above |
Hi, do you have any updates on this PR? It would help simplify our pipeline process. |
Can you please squash the commits and force-push? Thanks |
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
Hi @gastaldi, when do you plan to merge and release it? |
Thanks! |
This PR sorts by name only the env vars generate in the VanillaKubernetesProcessor (and DevClusterHelper, I don't know if this is needed as well). However, other vars generated from other parts of the code are not taken into account, for instance the
KUBERNETES_NAMESPACE
var.For me this is mostly sufficient, since the namespace var does not change and is always the first one.
However: