-
Notifications
You must be signed in to change notification settings - Fork 3k
Properly support Optional as a header param for REST Client #47368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
geoand
commented
Apr 15, 2025
- Fixes: Optional<> @HeaderParam REST Client arguments #47366
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this code is copied for sub resources in handleSubResourceMethod starting around line 1680. Could you please add a test for subresources?
|
Damn, I hate those rubresource :). |
This comment has been minimized.
This comment has been minimized.
|
|
|
FWIW, I would hold off backporting the second commit to 3.20 for the time being |
Status for workflow
|
|
@Postremus could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for muddling through the sub resources handling!
We can add support for optional for other parameter types (e.g. Query) in a follow up PR.
|
Makes sense! |