Skip to content

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 15, 2025

Copy link
Member

@Postremus Postremus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this code is copied for sub resources in handleSubResourceMethod starting around line 1680. Could you please add a test for subresources?

@geoand
Copy link
Contributor Author

geoand commented Apr 15, 2025

Damn, I hate those rubresource :).

This comment has been minimized.

@geoand
Copy link
Contributor Author

geoand commented Apr 15, 2025

As expected, those subresources are causing all sorts of problems .... Should be fixed now

@geoand
Copy link
Contributor Author

geoand commented Apr 15, 2025

FWIW, I would hold off backporting the second commit to 3.20 for the time being

Copy link

quarkus-bot bot commented Apr 15, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 3ad6e97.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxConnectionMetricsTest.testConnectionMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:353)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:346)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

@gsmet
Copy link
Member

gsmet commented Apr 15, 2025

@Postremus could you have another look?

Copy link
Member

@Postremus Postremus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for muddling through the sub resources handling!

We can add support for optional for other parameter types (e.g. Query) in a follow up PR.

@geoand
Copy link
Contributor Author

geoand commented Apr 15, 2025

Makes sense!

@geoand geoand merged commit 27e67c0 into quarkusio:main Apr 15, 2025
32 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 15, 2025
@gsmet gsmet modified the milestones: 3.22 - main, 3.21.3 Apr 15, 2025
@geoand geoand deleted the #47366 branch April 16, 2025 09:55
@gsmet gsmet modified the milestones: 3.21.3, 3.20.1 May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional<> @HeaderParam REST Client arguments

3 participants