Do not append email suffix if already present in oidc dev service #47296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sberyozkin
reviewed
Apr 10, 2025
...ons/devservices/oidc/src/main/java/io/quarkus/devservices/oidc/OidcDevServicesProcessor.java
Outdated
Show resolved
Hide resolved
Postremus
force-pushed
the
issues/47284-no-double-append-email-oidc-dev
branch
from
7f7639a to
10f5611
Compare
This comment has been minimized.
This comment has been minimized.
This prevents cases in the oidc dev service where [email protected] resulted in an email claim of [email protected]@example.com when retrieving a token. Make sure that the name claim contains no email address. use the name claim if present for the userInfo, otherwise the sub claim
Postremus
force-pushed
the
issues/47284-no-double-append-email-oidc-dev
branch
from
10f5611 to
9f7ae46
Compare
Status for workflow
|
sberyozkin
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents cases in the oidc dev service where [email protected] resulted in an email claim of user@[email protected] when retrieving a token. Make sure that the name claim contains no email address. use the name claim if present for the userInfo, otherwise the sub claim
closes #47284