Rename quarkus.hibernate-orm.database.generation to quarkus.hibernate-orm.schema-management.strategy #47252

gsmet · 2025-04-08T16:23:16Z

Also adjusted a couple of other properties in passing.

This is part of an overall effort to make YAML configuration less confusing and avoid having to use ~.

quarkus-bot · 2025-04-08T16:24:59Z

/cc @marko-bekhta (hibernate-search)

github-actions · 2025-04-08T16:55:47Z

🙈 The PR is closed and the preview is expired.

marko-bekhta · 2025-04-08T19:41:57Z

...src/main/java/io/quarkus/hibernate/orm/runtime/HibernateOrmRuntimeConfigPersistenceUnit.java

         *
         * Accepted values: `none`, `create`, `drop-and-create`, `drop`, `update`, `validate`.
         */
        @WithParentName


since it's generation.strategy in the properties files, do we need to keep the @WithParentName ?

yrodiere · 2025-04-09T08:15:18Z

So... I'm all for renaming, but if we're going that route, we might want to plan for the other renamings that we might need later?

See in particular this comment: #21866 (comment)

If I dared, I would suggest to go further and:

rename quarkus.hibernate-orm.database.generation to quarkus.hibernate-orm.schema-management.strategy. Because, you know, it's not just about "generation"! There's drop, too. Alternatively, I suppose quarkus.hibernate-orm.schema-management.action would work, too.

introduce a completely separate category with quarkus.hibernate-orm.data-management: quarkus.hibernate-orm.data-management.import-script, but also quarkus.hibernate-orm.data-management.strategy. The strategies would be none and import, the default being none in prod and import otherwise.

gsmet · 2025-04-18T12:32:29Z

@yrodiere this is now ready!

marko-bekhta

This looks nice 🎉 !

only have that one question about using two properties at the same time (added inline)

marko-bekhta · 2025-04-22T13:06:16Z

...ime/src/main/java/io/quarkus/hibernate/orm/runtime/FastBootHibernatePersistenceProvider.java

+                persistenceUnitConfig.database().generation().generation()
+                        .orElse(persistenceUnitConfig.schemaManagement().strategy()));


So, if the user applies both, then the deprecated option will "win"?
maybe we should check how the two match (or new one is none) and fail ? (if so, the same would apply to other options in this config)

Yeah, we sure could. But I think it's going to be a bit annoying as you can't really know if the new config is set or not (if it's set to the default) if you don't make it optional.

And it makes dropping the old stuff a bit more painful.

But if you feel like it, feel free to build on it once this is in.

yrodiere

Thanks. LGTM overall, but I think there's a small problem in dev service behavior...

.../src/main/java/io/quarkus/hibernate/orm/deployment/dev/HibernateOrmDevServicesProcessor.java

Also make sure we use .strategy instead of a @WithParentName property. This is part of an overall effort to make YAML configuration less confusing and avoid having to use `~`. Also related to: quarkusio#21866 (comment)

quarkus-bot · 2025-04-25T12:28:52Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 18bd561.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-04-28T09:14:29Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 18bd561.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

yrodiere · 2025-04-28T09:41:57Z

@gsmet Merged, thanks! Will you add something to the migration guide (and maybe quarkus update)?

lucamolteni · 2025-05-06T13:28:53Z

Quickstarts updated quarkusio/quarkus-quickstarts#1528

gsmet · 2025-05-06T13:46:53Z

@lucamolteni awesome, that was on my TODO list.

I will prepare the entry in the migration guide and also the Quarkus Updates recipe.

gsmet requested a review from yrodiere April 8, 2025 16:23

quarkus-bot bot added area/cache area/flyway area/gradle Gradle area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/hibernate-reactive Hibernate Reactive area/infinispan Infinispan area/panache area/spring Issues relating to the Spring integration labels Apr 8, 2025

marko-bekhta reviewed Apr 8, 2025

View reviewed changes

gsmet force-pushed the rename-strategy branch from 6977507 to 96790b6 Compare April 11, 2025 08:01

quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/vertx labels Apr 11, 2025

gsmet changed the title ~~Rename quarkus.hibernate-orm.generation to generation.strategy~~ Rename quarkus.hibernate-orm.database.generation to quarkus.hibernate-orm.schema-management.strategy Apr 11, 2025

yrodiere mentioned this pull request Apr 11, 2025

Support import.sql or similar facility for data population when not using Hibernate to create the schema #21866

Open

gsmet force-pushed the rename-strategy branch from 96790b6 to 5b272ba Compare April 17, 2025 17:46

gsmet marked this pull request as ready for review April 18, 2025 12:32

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Apr 18, 2025

gsmet requested a review from marko-bekhta April 18, 2025 15:23

marko-bekhta approved these changes Apr 22, 2025

View reviewed changes

yrodiere requested changes Apr 25, 2025

View reviewed changes

.../src/main/java/io/quarkus/hibernate/orm/deployment/dev/HibernateOrmDevServicesProcessor.java Outdated Show resolved Hide resolved

Rename quarkus.hibernate-orm.database.generation schema-management

18bd561

Also make sure we use .strategy instead of a @WithParentName property. This is part of an overall effort to make YAML configuration less confusing and avoid having to use `~`. Also related to: quarkusio#21866 (comment)

gsmet force-pushed the rename-strategy branch from 5b272ba to 18bd561 Compare April 25, 2025 11:59

yrodiere approved these changes Apr 25, 2025

View reviewed changes

yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 25, 2025

This comment has been minimized.

Sign in to view

yrodiere merged commit 81f6bbc into quarkusio:main Apr 28, 2025
60 checks passed

quarkus-bot bot added this to the 3.23 - main milestone Apr 28, 2025

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 28, 2025

yrodiere mentioned this pull request May 7, 2025

Fix Hibernate Documentation after Quickstart review #47709

Merged

marko-bekhta mentioned this pull request Jul 11, 2025

Change the database.generation to schema-management.strategy in the docs #48878

Merged

marko-bekhta mentioned this pull request Jul 29, 2025

Updating schema management property name #49135

Closed

		persistenceUnitConfig.database().generation().generation()
		.orElse(persistenceUnitConfig.schemaManagement().strategy()));

Rename quarkus.hibernate-orm.database.generation to quarkus.hibernate-orm.schema-management.strategy #47252

Rename quarkus.hibernate-orm.database.generation to quarkus.hibernate-orm.schema-management.strategy #47252

Uh oh!

Conversation

gsmet commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quarkus-bot bot commented Apr 8, 2025

Uh oh!

github-actions bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marko-bekhta Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiere commented Apr 9, 2025

Uh oh!

gsmet commented Apr 18, 2025

Uh oh!

This comment has been minimized.

marko-bekhta left a comment

Choose a reason for hiding this comment

Uh oh!

marko-bekhta Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

gsmet Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiere left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

quarkus-bot bot commented Apr 25, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

This comment has been minimized.

quarkus-bot bot commented Apr 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Uh oh!

Uh oh!

yrodiere commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucamolteni commented May 6, 2025

Uh oh!

gsmet commented May 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gsmet commented Apr 8, 2025 •

edited

Loading

github-actions bot commented Apr 8, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Apr 28, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`

yrodiere commented Apr 28, 2025 •

edited

Loading