-
Notifications
You must be signed in to change notification settings - Fork 3k
Postpone Stork shutdown #47202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postpone Stork shutdown #47202
Conversation
Stork can be used during shutdown tasks, and so should be stopped last.
|
@holly-cummins Hopefully this won't break the other things I did... |
Status for workflow
|
|
thanks @cescoffier . happy to try it out |
|
I was also unsure how to review without trying it, hence the delay (sorry!) but I'll rebase and confirm superheroes is still working with this. |
|
Confirmed, all good, no breaking of the other fixes. :) |
Stork can be used during shutdown tasks and should be stopped last.
Fix #41658