Skip to content

Conversation

@cescoffier
Copy link
Member

@cescoffier cescoffier commented Apr 7, 2025

Stork can be used during shutdown tasks and should be stopped last.

Fix #41658

Stork can be used during shutdown tasks, and so should be stopped last.
@cescoffier
Copy link
Member Author

@holly-cummins Hopefully this won't break the other things I did...

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 7, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 2406383.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry-grpc-only

io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

  • java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:672)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:770)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

@gastaldi gastaldi merged commit 39c187c into quarkusio:main Apr 8, 2025
43 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 8, 2025
@vsevel
Copy link
Contributor

vsevel commented Apr 8, 2025

thanks @cescoffier . happy to try it out

@holly-cummins
Copy link
Contributor

I was also unsure how to review without trying it, hence the delay (sorry!) but I'll rebase and confirm superheroes is still working with this.

@holly-cummins
Copy link
Contributor

Confirmed, all good, no breaking of the other fixes. :)

@gsmet gsmet modified the milestones: 3.22 - main, 3.21.2 Apr 8, 2025
@cescoffier cescoffier deleted the fix-41658 branch April 9, 2025 09:16
@jmartisk jmartisk modified the milestones: 3.21.2, 3.20.1 Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

graceful shutdown NPE when using kafka consumer with stork

6 participants