Skip to content

Properly reset mocks #47181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

Properly reset mocks #47181

merged 2 commits into from
Apr 4, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 4, 2025 •
edited
Loading

geoand added 2 commits April 4, 2025 16:04
@geoand
Properly reset mocks
07965d6 
When we moved to the inline mocks, clearing
the mocks was done incorrectly.

Fixes: quarkusio#47179
@geoand
Polish mocking code
dd998af
@geoand geoand requested a review from gsmet April 4, 2025 13:05
@geoand geoand mentioned this pull request Apr 4, 2025
Closed
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Apr 4, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dd998af.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 83f8ebe into quarkusio:main Apr 4, 2025
32 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 4, 2025
@geoand geoand deleted the #47179 branch April 4, 2025 13:37
geoand added a commit to geoand/quarkus that referenced this pull request Apr 7, 2025
@geoand
Properly rest mocks (again)
144c99e 
Follows up on: quarkusio#47181
@geoand geoand mentioned this pull request Apr 7, 2025
Merged
@geoand
Copy link
Contributor Author

geoand commented Apr 7, 2025

#47214 will also have to be backported if this one is

@gsmet gsmet modified the milestones: 3.22 - main, 3.21.2 Apr 8, 2025
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Apr 8, 2025
@geoand @gsmet
Properly rest mocks (again)
f00cf33 
Follows up on: quarkusio#47181

(cherry picked from commit 144c99e)
junes189 pushed a commit to junes189/quarkus that referenced this pull request Apr 9, 2025
@geoand @junes189
Properly rest mocks (again)
cddaa1a 
Follows up on: quarkusio#47181
DavideD pushed a commit to DavideD/quarkus that referenced this pull request Apr 9, 2025
@geoand @DavideD
Properly rest mocks (again)
a156178 
Follows up on: quarkusio#47181
@jmartisk jmartisk modified the milestones: 3.21.2, 3.20.1 Apr 30, 2025
jmartisk pushed a commit to jmartisk/quarkus that referenced this pull request Apr 30, 2025
@geoand @jmartisk
Properly rest mocks (again)
21967a0 
Follows up on: quarkusio#47181

(cherry picked from commit 144c99e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

No one assigned

Labels

area/testing kind/bugfix refresh-issue-index

Projects

None yet

Milestone

3.20.1

Development

Successfully merging this pull request may close these issues.

Since Quarkus 3.19 quarkus-junit5-mockito doesn't clean up mocks properly when used in combination with @TestInstance(TestInstance.Lifecycle.PER_CLASS)

3 participants

@geoand @gsmet @jmartisk