Skip to content

Make TlsConfiguration#getName a default method #47170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Make TlsConfiguration#getName a default method #47170

merged 1 commit into from
Apr 4, 2025
+6 −1

Conversation

@geoand
Copy link
Contributor

@geoand geoand commented Apr 4, 2025

This was done in order to unbreak integrations
in 3.20 LTS

Follows up on #46961.

cc @cescoffier @ppalaga

@geoand geoand mentioned this pull request Apr 4, 2025
Merged
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 4, 2025
@quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

🎊 PR Preview 3040546 has been successfully built and deployed to https://quarkus-pr-main-47170-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

ppalaga
ppalaga reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, @geoand

This was done in order to unbreak integrations in 3.20 LTS

The getName() method is not available in 3.20 yet. So you plan to backport it?

extensions/tls-registry/spi/src/main/java/io/quarkus/tls/TlsConfiguration.java
*/
String getName();
default String getName() {
return "unset";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a unique default name be better - something like

Suggested change
return "unset";
return "tls-configutation-" + System.identityHashCode(this);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why it would be

@geoand
Copy link
Contributor Author

geoand commented Apr 4, 2025

The getName() method is not available in 3.20 yet. So you plan to backport it?

If #46961 is, yes

@geoand @ppalaga
Make TlsConfiguration#getName a default method
e0944f8 
This was done in order to unbreak integrations
in 3.20 LTS

Co-authored-by: Peter Palaga <[email protected]>
@ppalaga ppalaga mentioned this pull request Apr 4, 2025
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 4, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e0944f8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 4, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e0944f8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 637af39 into quarkusio:main Apr 4, 2025
58 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 4, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 4, 2025
@geoand geoand deleted the tlsconfig-name branch April 7, 2025 05:35
@gsmet gsmet modified the milestones: 3.22 - main, 3.21.2 Apr 8, 2025
@jmartisk jmartisk modified the milestones: 3.21.2, 3.20.1 Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cescoffier cescoffier cescoffier approved these changes

+1 more reviewer

@ppalaga ppalaga ppalaga left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/config

Projects

None yet

Milestone

3.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@geoand @cescoffier @ppalaga @jmartisk @gsmet