Skip to content

Conversation

@geoand
Copy link
Contributor

@geoand geoand commented Apr 2, 2025

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Apr 2, 2025
Comment on lines +50 to +51
@WithName("kotlin.generate")
Optional<Boolean> generateKotlin();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
@WithName("kotlin.generate")
Optional<Boolean> generateKotlin();
Optional<Boolean> kotlinGenerate();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was the default IntelliJ suggested as well but I prefer methods to read with verb first (not that it really matters at all in this case).

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 2, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 28adc26.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions
Copy link

github-actions bot commented Apr 2, 2025

🎊 PR Preview dbf4d28 has been successfully built and deployed to https://quarkus-pr-main-47139-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 2, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 28adc26.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry-grpc-only

io.quarkus.it.opentelemetry.grpc.HelloGrpcClientTest.testHello - History

  • java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:672)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:770)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
  • java.lang.RuntimeException: Failed to start quarkus - java.lang.RuntimeException
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:672)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:770)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

@geoand geoand merged commit 5a7d9c8 into quarkusio:main Apr 2, 2025
42 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 2, 2025
@geoand geoand deleted the #47134 branch April 3, 2025 06:39
@gsmet gsmet modified the milestones: 3.22 - main, 3.21.2 Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Protobuf kotlin generation configuration produces Unrecognized configuration key

3 participants