-
Notifications
You must be signed in to change notification settings - Fork 3k
Ensure gRPC server starts after Otel is configured (if applicable) #47076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can add an IT test to the PR... We don't have a specific test just with gRPC, without Quarkus Rest. |
I updated the PR to add Opentelemetry to one of the existing ones |
Double checked and the test does not reproduce the condition on my machine. |
Of course, go right ahead |
The fix sounds good @geoand. |
Status for workflow
|
List<FilterBuildItem> filterBuildItems) { | ||
List<FilterBuildItem> filterBuildItems, | ||
// used to ensure that gRPC server starts after OTel has been set up | ||
@SuppressWarnings("unused") BeanContainerBuildItem beanContainerBuildItem) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about if we're more specific / exact, to "wait" for OTel, not an entire ArC?
e.g. to add some new build item, if needed ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried one of the BuildItem classes we already have in OTel and unfortunately it didn't work because although gRPC server started after OTel, the OTel bean is lazy and still caused the same problem
Nice 🙂 |
Uh oh!
There was an error while loading. Please reload this page.