Skip to content

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 31, 2025

@brunobat
Copy link
Contributor

I can add an IT test to the PR... We don't have a specific test just with gRPC, without Quarkus Rest.

@geoand
Copy link
Contributor Author

geoand commented Mar 31, 2025

I updated the PR to add Opentelemetry to one of the existing ones

@brunobat
Copy link
Contributor

brunobat commented Mar 31, 2025

Double checked and the test does not reproduce the condition on my machine.
Will add a new, simpler IT test, if you don't mind.

@geoand
Copy link
Contributor Author

geoand commented Mar 31, 2025

Of course, go right ahead

@brunobat
Copy link
Contributor

The fix sounds good @geoand.
I was thinking on an IT test like this for a while... I even have one in a draft somewhere, for other reasons.

@geoand geoand marked this pull request as ready for review March 31, 2025 19:52
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 31, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9fec960.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand requested a review from brunobat April 1, 2025 06:16
@brunobat brunobat merged commit ce065c1 into quarkusio:main Apr 1, 2025
70 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Apr 1, 2025
List<FilterBuildItem> filterBuildItems) {
List<FilterBuildItem> filterBuildItems,
// used to ensure that gRPC server starts after OTel has been set up
@SuppressWarnings("unused") BeanContainerBuildItem beanContainerBuildItem) {
Copy link
Contributor

@alesj alesj Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if we're more specific / exact, to "wait" for OTel, not an entire ArC?
e.g. to add some new build item, if needed ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried one of the BuildItem classes we already have in OTel and unfortunately it didn't work because although gRPC server started after OTel, the OTel bean is lazy and still caused the same problem

@geoand geoand deleted the #47062 branch April 1, 2025 11:44
@gsmet gsmet modified the milestones: 3.22 - main, 3.21.1 Apr 1, 2025
@geoand
Copy link
Contributor Author

geoand commented Apr 2, 2025

Nice 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constructor injection of io.opentelemetry.api.metrics.Meter in a @GrpcService-annotated class makes tests fail

4 participants