Skip to content

Conversation

@aloubyansky
Copy link
Member

This change includes a test that illustrates the use-case.

Basically, when two registries are configured and the primary one recommends a platform based on a Quarkus version that is not promoted anymore by the second registry, when a user creates a new projects using extensions from the platform from the second registry, the latest version of the platform provided by the second registry should be selected.

Before this change, the registry client would select a platform version that was based on the same version Quarkus that the primary registry recommends.

…ferrences than those referenced from downstream platforms
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Mar 27, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9a129c8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/infinispan-cache/deployment

io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

  • expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)

@gastaldi gastaldi merged commit 5bd9ae8 into quarkusio:main Mar 28, 2025
56 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Mar 28, 2025
@gsmet
Copy link
Member

gsmet commented Apr 1, 2025

@aloubyansky is it something we want to backport?

@aloubyansky
Copy link
Member Author

I think we could backport it.
Generally, it's not changing how extensions are selected in case when both the Red Hat and the community registries are configured due to how the Red Hat platform is built.
The difference will be seen when platforms from different registries provide different extensions. So this will make sense for orgs that build their custom platforms and setup their own registries.

@gsmet gsmet modified the milestones: 3.22 - main, 3.21.2 Apr 8, 2025
@gsmet gsmet changed the title Make sure default platforms recommended by registries have higher preferrences than those referenced from downstream platforms Make sure default platforms recommended by registries have higher preferences than those referenced from downstream platforms Apr 8, 2025
@jmartisk jmartisk modified the milestones: 3.21.2, 3.20.1 Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants