-
Notifications
You must be signed in to change notification settings - Fork 3k
OpenAPI: disable example merging by default (Swagger UI regression) #46956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview d83f84f has been successfully built and deployed to https://quarkus-pr-main-46956-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. You probably need to adjust the TCK test configuration to use this new config though.
What's the plan for when Swagger actually handles this correctly?
👍 , this will likely have some impact on tests as well, FYI @michalvavrik
Later versions of Swagger should handle either |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Michael Edgar <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
Status for workflow
|
Status for workflow
|
|
@MikeEdgar I merged this one. What I suggest is to prepare another PR to undo part of that and update Swagger UI. Once released for some time, we can rediscuss if it makes sense to push it to 3.20 LTS. Thanks! |

Closes #46628
Disables by default the automatic merging of OpenAPI schema
exampleinto the newexamplesarray introduced in the OpenAPI specification version 3.1.0. See Swagger UI issue described in #46628 that is affected by the merging of examples.Users may enable the new configuration property if desired.