Skip to content

Metrics extension should not add Dependent scope to JAX-RS provider classes #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2019
Merged

Metrics extension should not add Dependent scope to JAX-RS provider classes #4688

merged 1 commit into from
Oct 21, 2019

Conversation

jmartisk
Copy link
Contributor

…lasses

#4667

@jmartisk jmartisk requested a review from mkouba October 21, 2019 09:35
mkouba
mkouba approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. isJaxRsProvider() is redundant but it's better safe than sorry ;-).

@gsmet gsmet added this to the 0.27.0 milestone Oct 21, 2019
@gsmet gsmet added backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 21, 2019
@gsmet
Copy link
Member

gsmet commented Oct 21, 2019

Merged, thanks!

@gsmet gsmet merged commit a10face into quarkusio:master Oct 21, 2019
@gsmet gsmet changed the title Metrics extension should not add Dependent scope to JAX-RS provider c… Metrics extension should not add Dependent scope to JAX-RS provider classes Oct 21, 2019
@gsmet gsmet removed the backport? label Oct 21, 2019
@gsmet gsmet modified the milestones: 0.27.0, 0.26.0 Oct 21, 2019
@gsmet gsmet mentioned this pull request Oct 21, 2019
Closed
@jmartisk jmartisk deleted the master-issue-4667 branch October 21, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkouba mkouba mkouba approved these changes

@gsmet gsmet gsmet approved these changes

Assignees

No one assigned

Labels

triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jmartisk @gsmet @mkouba