Skip to content

Conversation

@holly-cummins
Copy link
Contributor

@holly-cummins holly-cummins commented Mar 13, 2025

The tests don't pass now (see #38987), but they will be fixed by incoming changes, and at that point we would like them to continue working.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 13, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@holly-cummins holly-cummins changed the title Add disabled reproducer for #38987 Add disabled reproducer for mockito mocking inner classes in continuous testing Mar 13, 2025
@quarkus-bot

This comment has been minimized.

@holly-cummins holly-cummins requested review from geoand and removed request for geoand March 13, 2025 12:34
@holly-cummins holly-cummins marked this pull request as draft March 13, 2025 12:40
@holly-cummins holly-cummins force-pushed the mockito-reproducer branch 2 times, most recently from 86e0d7b to 43ee479 Compare March 13, 2025 14:08
@holly-cummins holly-cummins marked this pull request as ready for review March 13, 2025 15:57
@holly-cummins
Copy link
Contributor Author

Example of the tests running green when not-disabled (in a branch which has the test classloading update): https://github.com/quarkusio/quarkus/actions/runs/13837159879/job/38715858259

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 13, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 13, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 87440c4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 54865b4 into quarkusio:main Mar 14, 2025
38 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 14, 2025
@quarkus-bot quarkus-bot bot added this to the 3.22 - main milestone Mar 14, 2025
@holly-cummins holly-cummins deleted the mockito-reproducer branch March 14, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants