Skip to content

Shorter json classes in guides #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2019
Merged

Shorter json classes in guides #4654

merged 2 commits into from
Oct 21, 2019

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Oct 18, 2019

Fixes #4636

aguibert
aguibert approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@aguibert aguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! public fields on JSON model classes are best practice whenever possible

@gsmet gsmet added this to the 0.27.0 milestone Oct 21, 2019
@gsmet gsmet merged commit ff0fbd6 into quarkusio:master Oct 21, 2019
@gsmet gsmet modified the milestones: 0.27.0, 0.26.0 Oct 21, 2019
@gsmet gsmet removed the backport? label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsmet gsmet gsmet approved these changes

+1 more reviewer

@aguibert aguibert aguibert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.26.0

Development

Successfully merging this pull request may close these issues.

Shorter JSON classes in guides

3 participants

@FroMage @gsmet @aguibert