Skip to content

Conversation

jaikiran
Copy link
Member

As noted in #2326 (comment), the .sql files which were previously present within the flyway jar are no longer present in it and are instead inlined into various java files. The code in our Flyway extension which was adding these files are substrate resources is effectively a no-op now. This commit removes that code.

For verification, here's what 5.x of flyway had:

jar -tf .m2/repository/org/flywaydb/flyway-core/5.2.4/flyway-core-5.2.4.jar  | grep \\.sql

org/flywaydb/core/internal/database/redshift/createMetaDataTable.sql
org/flywaydb/core/internal/database/saphana/createMetaDataTable.sql
org/flywaydb/core/internal/database/hsqldb/createMetaDataTable.sql
org/flywaydb/core/internal/database/sqlite/createMetaDataTable.sql
org/flywaydb/core/internal/database/cockroachdb/createMetaDataTable.sql
org/flywaydb/core/internal/database/mysql/createMetaDataTable.sql
org/flywaydb/core/internal/database/oracle/createMetaDataTable.sql
org/flywaydb/core/internal/database/h2/createMetaDataTable.sql
org/flywaydb/core/internal/database/derby/createMetaDataTable.sql
org/flywaydb/core/internal/database/sybasease/createMetaDataTable.sql
org/flywaydb/core/internal/database/postgresql/createMetaDataTable.sql

6.0.6 (the version we now use) doesn't have those anymore:

jar -tf .m2/repository/org/flywaydb/flyway-core/6.0.6/flyway-core-6.0.6.jar  | grep \\.sql

returns empty.

@Sanne Sanne self-assigned this Oct 17, 2019
@Sanne Sanne added area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request labels Oct 17, 2019
@Sanne Sanne added this to the 0.26.0 milestone Oct 17, 2019
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@gsmet gsmet merged commit 2e0f7cd into quarkusio:master Oct 17, 2019
@gsmet
Copy link
Member

gsmet commented Oct 17, 2019

Merged, thanks!

@jaikiran jaikiran deleted the qk-2326 branch October 18, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants