- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3k
Restructure TLS Registry Extension #46387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure TLS Registry Extension #46387
Conversation
| /cc @brunobat (opentelemetry), @radcortez (opentelemetry) | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| 🎊 PR Preview 519f562 has been successfully built and deployed to https://quarkus-pr-main-46387-preview.surge.sh/version/main/guides/ 
 | 
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes perfect sense to me
        
          
                extensions/tls-registry/spi/src/main/java/io/quarkus/tls/TrustAllOptions.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      1ecd436    to
    8e93ec3      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
This commit reorganizes the TLS registry extension according to the guidelines discussed in quarkusio#43130. The restructuring addresses the issue logged in quarkusio#44711. As a result of this change, extensions relying on the TLS registry build item will encounter a breaking change due to the updated package name.
8e93ec3    to
    dea354a      
    Compare
  
    | Status for workflow  | 
| Status for workflow  | 
| Status | Name | Step | Failures | Logs | Raw logs | Build scan | 
|---|---|---|---|---|---|---|
| ✖ | MicroProfile TCKs Tests | Verify | Failures | Logs | Raw logs | 🔍 | 
You can consult the Develocity build scans.
Failures
⚙️ MicroProfile TCKs Tests #
- Failing: tcks/microprofile-opentelemetry 
📦 tcks/microprofile-opentelemetry
✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (tracing) on project quarkus-tck-microprofile-opentelemetry: There are test failures.
See /home/runner/_work/quarkus/quarkus/tcks/microprofile-opentelemetry/target/surefire-reports-tracing for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17 Windows
📦 extensions/hibernate-orm/deployment
✖ io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess - History
- Expecting actual not to be null-- java.lang.AssertionError
java.lang.AssertionError: 
Expecting actual not to be null
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest$FieldAccessEnhancedDelegate$2.assertValue(PublicFieldAccessInheritanceTest.java:152)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.doTestFieldAccess(PublicFieldAccessInheritanceTest.java:100)
	at io.quarkus.hibernate.orm.applicationfieldaccess.PublicFieldAccessInheritanceTest.testFieldAccess(PublicFieldAccessInheritanceTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

This PR reorganizes the TLS registry extension according to the guidelines discussed in #43130.
Fixes #44711.
This change will result in extensions relying on the TLS registry build item encountering a breaking change due to the updated package name.