#4587: Reversed isAssignableFrom arguments #4628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cescoffier How do you want to deal with the testing part of this PR? Should we add a full blown integration test in the |
|
Can you please rebase your PR onto the latest master in order to pick up a fix for CI? Thanks |
|
We would need another PR with tests. Test would cover this but also other usages. |
|
So once rebased, and if CI is green, let's merge that and open another PR with tests. |
geoand
approved these changes
Oct 21, 2019
geoand
added
the
triage/waiting-for-ci
|
@misl are you sure you rebased to the latest master? The native security tests are still failing and I am not seing that failure in other PRs. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuarkusMediatorConfigurationUtil.JandexGenericTypeAssignable.check() results in NotAssignable where Assignable is expected. Especially the following part: argumentClass.isAssignableFrom(target). This basically results in AmqpMessage.isAssignableFrom(Message) or MqttMessage.isAssignableFrom(Message). This should be the other way around Message.isAssignableFrom(AmqpMessage).