Skip to content

Conversation

aguibert
Copy link
Member

While using Gradle dev mode (i.e. ./gradlew quarkusDev) my project only had a src/main/java folder but no src/main/resources folder. The devtools plugin blew up when trying to scan the resources dir for file changes when it did not exist:

2019-10-16 12:48:21,127 ERROR [io.qua.dev] (vert.x-worker-thread-0) Failed to copy resources: java.nio.file.NoSuchFileException: /Users/aguibert/dev/git/basic-quarkus/src/main/resources
        at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92)
        at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
        at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116)
        at java.base/sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:55)
        at java.base/sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:145)
        at java.base/java.nio.file.Files.readAttributes(Files.java:1763)
        at java.base/java.nio.file.FileTreeWalker.getAttributes(FileTreeWalker.java:219)
        at java.base/java.nio.file.FileTreeWalker.visit(FileTreeWalker.java:276)
        at java.base/java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:322)
        at java.base/java.nio.file.FileTreeIterator.<init>(FileTreeIterator.java:71)
        at java.base/java.nio.file.Files.walk(Files.java:3820)
        at java.base/java.nio.file.Files.walk(Files.java:3874)
        at io.quarkus.dev.RuntimeUpdatesProcessor.checkForFileChange(RuntimeUpdatesProcessor.java:304)
        at io.quarkus.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:121)
        at io.quarkus.vertx.http.deployment.devmode.VertxHotReplacementSetup$1.handle(VertxHotReplacementSetup.java:52)
        at io.quarkus.vertx.http.deployment.devmode.VertxHotReplacementSetup$1.handle(VertxHotReplacementSetup.java:44)
        at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:316)
        at io.vertx.core.impl.ContextImpl$$Lambda$422.00000000DD584020.run(Unknown Source)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:831)

@aguibert
Copy link
Member Author

@ia3andy can you please review when you get a chance?

gsmet
gsmet previously requested changes Oct 16, 2019
@aguibert aguibert force-pushed the devmode-no-resources-folder branch from d50d509 to 3020709 Compare October 17, 2019 04:16
@geoand geoand requested a review from ia3andy October 17, 2019 06:18
@geoand geoand dismissed gsmet’s stale review October 17, 2019 06:19

comment addressed

@ia3andy
Copy link
Contributor

ia3andy commented Oct 17, 2019

@aguibert is there a way to add a failing test that your PR fixes?

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I do prefer when fixes are coming with tests 😇

@gsmet gsmet merged commit c894ad6 into quarkusio:master Oct 17, 2019
@gsmet
Copy link
Member

gsmet commented Oct 17, 2019

Merged, thanks!

@gsmet gsmet added this to the 0.26.0 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants