-
Notifications
You must be signed in to change notification settings - Fork 3k
Spring DI - Fix behavior with named beans #46140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks reasonable but I did not check the other parts of the SpringDIProcessor and how exactly we map spring annotations to @Named...
Also pls squash the commits and maybe add a more "informative" commit description.
|
Yes @mkouba I will do it. It had to be a draft |
...gration-tests/spring-di/src/main/java/io/quarkus/it/spring/MyConfigurationWithNamedBean.java
Outdated
Show resolved
Hide resolved
0ec3525 to
37dc798
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the fix!
Fixes #45961
This pull request aims to solve an issue when using
@Namedannotation.Having the following code below:
This change uses the value instead the name, removing the
UnsatisfiedResolutionException.