Skip to content

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Oct 16, 2019

While working on other (TBD) tests, I'm finding myself often needing to copy various new application.properties resources just to test a couple of flag permutations.

This makes it a bit more convenient.

It also defines a default Archive Producer, which allows to not have to set one when there's no need to add any additional classes/beans to the app.

Copy link
Member

@aguibert aguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor

geoand commented Oct 18, 2019

Can you please rebase onto the latest master?

There is a CI fix that should take care of the error reported.

Thanks

@Sanne
Copy link
Member Author

Sanne commented Oct 18, 2019

Rebased. Thanks @geoand ! Could you also approve it?

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@geoand
Copy link
Contributor

geoand commented Oct 18, 2019

@Sanne done!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 18, 2019
@geoand geoand merged commit 68e0378 into quarkusio:master Oct 18, 2019
@Sanne Sanne deleted the PropsHelper branch October 18, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants