Skip to content

Conversation

@gefloh
Copy link
Contributor

@gefloh gefloh commented Feb 1, 2025

This PR fixes a couple of small Javadoc/MD syntax issues. It might seem completely unimportant, but there are cases where it shows up in the public documentation which is not nice.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kubernetes area/mailer area/maven area/redis area/vertx labels Feb 1, 2025
@gefloh gefloh marked this pull request as draft February 1, 2025 11:34
@gefloh gefloh marked this pull request as ready for review February 1, 2025 11:37
@gsmet
Copy link
Member

gsmet commented Feb 1, 2025

I’ll have a look on Monday. Doc fixes are always very welcome!

@gefloh
Copy link
Contributor Author

gefloh commented Feb 1, 2025

@gsmet Yeah I'm good in finding stuff like that. ;-) Have a nice weekend.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch for everything, thanks a lot. Keep them coming if you find other issues :).

Will let CI check things and we can merge.

Have a nice week-end too!

@gefloh
Copy link
Contributor Author

gefloh commented Feb 1, 2025

I will keep my eyes open. :-) Thanks.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 1, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8b5b7ff.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions
Copy link

github-actions bot commented Feb 1, 2025

🎊 PR Preview baedd86 has been successfully built and deployed to https://quarkus-pr-main-46031-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 1, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8b5b7ff.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-context-propagation

io.quarkus.it.kafka.KafkaContextPropagationTest.testAbsenceOfContextPropagation - History

  • 1 expectation failed. Expected status code <500> but was <204>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <500> but was <204>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

io.quarkus.it.kafka.KafkaContextPropagationTest.testAbsenceOfContextPropagationBlocking - History

  • 1 expectation failed. Expected status code <500> but was <204>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <500> but was <204>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Async - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:236)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Async(MicrometerTimedInterceptorTest.java:126)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed(MicrometerTimedInterceptorTest.java:150)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

@gefloh gefloh requested a review from gsmet February 1, 2025 19:56
@gsmet gsmet merged commit 518a690 into quarkusio:main Feb 2, 2025
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 2, 2025
@gsmet
Copy link
Member

gsmet commented Feb 2, 2025

Thanks!

@gefloh gefloh deleted the fix-syntax branch February 3, 2025 07:46
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.2 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/arc Issue related to ARC (dependency injection) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/kubernetes area/mailer area/maven area/redis area/tracing area/vertx triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants