Skip to content

DOCS: Add downstream-relevant attributes to facilitate single sourcing #45962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

DOCS: Add downstream-relevant attributes to facilitate single sourcing #45962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/src/main/asciidoc/_attributes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,15 @@
// .
:create-app-group-id: org.acme
:create-cli-group-id: {create-app-group-id}
// Attributes required for single-sourcing to downstream.
:jdk-version-other: 17
:jdk-version-latest: 21
:jdk-version-all: 17 or 21
Comment on lines +71 to +73
Copy link
Member

@gsmet gsmet Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this to make progress but... I don't think this will fly but it's just an intuition as I have no idea how you plan to use them.

In the community, people can use any Java 17+ (typically, if they want to use Java 23, that's fine).

So please send me an email when you start using these, with a pointer, so that I can have a look.

Copy link
Contributor Author

@sheilamjones sheilamjones Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gsmet,

Thanks for your review. These attributes are used mainly in the Prerequisites section of the various procedures (in the other PRs that you are reviewing/merging as part of this effort) for deploying to OpenShift.

For example, in the Prerequisite, "You have OpenJDK {jdk-version-other} or later installed."

Per your request, I will update you via email with more details. Again, many thanks for your reviews and feedback.

:openshift-long: OpenShift
:openshift: OpenShift
:name-image-ubi9-open-jdk-17: registry.access.redhat.com/ubi9/openjdk-17
:name-image-ubi9-open-jdk-17-short: ubi9/openjdk-17
:name-image-ubi9-open-jdk-21: registry.access.redhat.com/ubi9/openjdk-21
:name-image-ubi9-open-jdk-21-short: ubi9/openjdk-21
// .
include::_attributes-local.adoc[]
Loading