Skip to content

Adjust logging level for JDBC resource leak warnings #45583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

Adjust logging level for JDBC resource leak warnings #45583

merged 1 commit into from
Jan 14, 2025

Conversation

@gastaldi
Copy link
Contributor

@gastaldi gastaldi requested a review from yrodiere January 14, 2025 16:20
@gastaldi
Adjust logging level for JDBC resource leak warnings
81a7c4b 
```
- Adjust JDBC resource leak logging to use debug level instead of warnings for better log granularity.
- Enhance developer experience by reducing noise in application logs.
```
@gastaldi
Copy link
Contributor Author

/cc @mabartos

yrodiere
yrodiere approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 14, 2025
@mabartos mabartos mentioned this pull request Jan 14, 2025
Closed
2 tasks
mabartos
mabartos approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@mabartos mabartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gastaldi Great, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 14, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 81a7c4b.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
✔️ JVM Tests - JDK 21 Logs Raw logs 🔍
✖ JVM Tests - JDK 17 Windows Clean Gradle temp directory ⚠️ Check → Logs Raw logs 🔍

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit bbf1153 into quarkusio:main Jan 14, 2025
42 of 43 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 14, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 14, 2025
@gastaldi gastaldi deleted the agroal_logging branch January 14, 2025 18:54
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.7 Jan 14, 2025
@jmartisk jmartisk modified the milestones: 3.17.7, 3.15.4 Feb 20, 2025
@yrodiere yrodiere linked an issue Mar 11, 2025 that may be closed by this pull request
Statement leak warning on start since 2.11.0.Final #26995
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yrodiere yrodiere yrodiere approved these changes

+1 more reviewer

@mabartos mabartos mabartos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/agroal kind/enhancement New feature or request

Projects

None yet

Milestone

3.15.4

Development

Successfully merging this pull request may close these issues.

Demote Agroal's "JDBC resources leaked" warnings to DEBUG Statement leak warning on start since 2.11.0.Final

5 participants

@gastaldi @yrodiere @mabartos @jmartisk @gsmet