WebSockets Next: use SPI to separate the Websockets extension from OpenTelemetry and Micrometer extensions #45522

michalvavrik · 2025-01-13T00:17:32Z

Integrate Micrometer with WebSockets Next #44379 (review)

quarkus-bot · 2025-01-13T00:17:56Z

/cc @brunobat (micrometer,opentelemetry), @ebullient (micrometer), @radcortez (opentelemetry)

github-actions · 2025-01-13T00:50:16Z

🎊 PR Preview dd7edc6 has been successfully built and deployed to https://quarkus-pr-main-45522-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

mkouba

Looks good but I cannot talk about the opentelemetry/micrometer part..

...ry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/tracing/TracerProcessor.java

...loyment/src/main/java/io/quarkus/micrometer/deployment/binder/WebSocketsBinderProcessor.java

gsmet · 2025-01-28T08:51:20Z

Hey @brunobat , could you have a look at this one? It looks like something we would want for the next LTS.

brunobat · 2025-01-28T09:35:34Z

I wish we had discussed this before implementing it because if we adopt the observation API in the future, we will need to rewrite it all again. Maybe we did, but I don't remember. Sorry.
Will review asap, but not today.

michalvavrik · 2025-01-28T10:01:30Z

I wish we had discussed this before implementing it because if we adopt the observation API in the future, we will need to rewrite it all again. Maybe we did, but I don't remember. Sorry. Will review asap, but not today.

I don't mind rewriting it again @brunobat .

michalvavrik · 2025-01-28T10:03:24Z

Maybe we did, but I don't remember.

no, we didn't, I didn't realize this could be improved, I am happy to meet you and rewrite this. Thanks

cescoffier · 2025-03-31T05:21:52Z

@brunobat any news?

brunobat

I've decided this is good to go.
We will need to handle whatever happens after Observability.next, afterwards.

gsmet · 2025-04-08T15:54:28Z

I rebased the PR to fix a conflict and get an updated CI run.

cescoffier

Looks ok, however, we need to verify that:

This is not a breaking change
There are no split packages

michalvavrik · 2025-04-13T21:18:11Z

I'll check early next week.

brunobat · 2025-04-24T15:52:44Z

rifier discovered a type not marked as reachable: AnalysisType<VMOption$Origin[] -> HotSpotType<[Lcom/sun/management/VMOption$Origin;, resolved>, allocated: false, inHeap: false, reachable: false>

Any chance it is this one #46890 ?

Makes sense, but I'm intrigued why we haven't seen this failure sooner...

michalvavrik · 2025-04-27T18:56:15Z

The failure is gone, MicrometerWebSocketsOnErrorTest seems flaky on Windows, but that won't be due to this PR (as it changes nothing functionally).

michalvavrik · 2025-04-27T18:57:11Z

I have requested 2 other reviews because it's unclear to me what is current situation (what are we waiting for with merging).

cescoffier

My only concern is the URI tag in metrics. CC @brunobat
It would be great to have the review from @mkouba

...io/quarkus/micrometer/runtime/binder/websockets/WebSocketMetricsInterceptorProducerImpl.java

...src/main/java/io/quarkus/websockets/next/runtime/spi/telemetry/WebSocketEndpointContext.java

mkouba

The WS Next part is ok. I just added a tiny nitpicking comment ;-).

...ain/java/io/quarkus/websockets/next/runtime/telemetry/TelemetryWebSocketEndpointContext.java

brunobat

Thanks @michalvavrik

michalvavrik · 2025-05-02T07:22:34Z

GH CI stuck on "CI Sanity Check" (Expected - Waiting for status to be reported). I'll rebase again.

quarkus-bot · 2025-05-02T08:01:35Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit ca75c71.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-05-02T10:41:09Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit ca75c71.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

michalvavrik requested review from brunobat and mkouba January 13, 2025 00:17

quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/metrics area/tracing labels Jan 13, 2025

michalvavrik changed the title ~~WebSockets Next: use SPI to separate websockets from OpenTelemetry and Micrometer extensions~~ WebSockets Next: use SPI to separate the Websockets extension from OpenTelemetry and Micrometer extensions Jan 13, 2025

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Jan 13, 2025

michalvavrik added the area/websockets label Jan 13, 2025

mkouba reviewed Jan 13, 2025

View reviewed changes

...ry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/tracing/TracerProcessor.java Outdated Show resolved Hide resolved

...loyment/src/main/java/io/quarkus/micrometer/deployment/binder/WebSocketsBinderProcessor.java Outdated Show resolved Hide resolved

michalvavrik force-pushed the feature/ws-next-micrometer-tests-and-spi branch from 139641c to 8d40ce1 Compare January 13, 2025 12:10

This comment has been minimized.

Sign in to view

brunobat approved these changes Mar 31, 2025

View reviewed changes

gsmet force-pushed the feature/ws-next-micrometer-tests-and-spi branch from 8d40ce1 to 151ee9c Compare April 8, 2025 15:53

gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 8, 2025

This comment has been minimized.

Sign in to view

cescoffier reviewed Apr 9, 2025

View reviewed changes

michalvavrik force-pushed the feature/ws-next-micrometer-tests-and-spi branch from 1d7326a to 4f52cf2 Compare April 27, 2025 14:40

This comment has been minimized.

Sign in to view

michalvavrik requested review from cescoffier and mkouba April 27, 2025 18:56

cescoffier approved these changes Apr 28, 2025

View reviewed changes

...io/quarkus/micrometer/runtime/binder/websockets/WebSocketMetricsInterceptorProducerImpl.java Show resolved Hide resolved

mkouba reviewed Apr 28, 2025

View reviewed changes

...src/main/java/io/quarkus/websockets/next/runtime/spi/telemetry/WebSocketEndpointContext.java Outdated Show resolved Hide resolved

mkouba approved these changes Apr 28, 2025

View reviewed changes

brunobat requested changes Apr 28, 2025

View reviewed changes

...ain/java/io/quarkus/websockets/next/runtime/telemetry/TelemetryWebSocketEndpointContext.java Show resolved Hide resolved

michalvavrik removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 30, 2025

michalvavrik force-pushed the feature/ws-next-micrometer-tests-and-spi branch from 4f52cf2 to 1e3128a Compare April 30, 2025 11:42

mkouba requested a review from brunobat April 30, 2025 12:17

This comment has been minimized.

Sign in to view

brunobat approved these changes Apr 30, 2025

View reviewed changes

mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 30, 2025

This comment has been minimized.

Sign in to view

michalvavrik force-pushed the feature/ws-next-micrometer-tests-and-spi branch from 1e3128a to d1e7009 Compare May 1, 2025 13:04

michalvavrik added 2 commits May 2, 2025 09:22

WebSockets Next: use SPI to separate WS from OTel and MP extensions

d6678cf

WebSockets Next: use SPI to separate WS from OTel and MP extensions

ca75c71

michalvavrik force-pushed the feature/ws-next-micrometer-tests-and-spi branch from d1e7009 to ca75c71 Compare May 2, 2025 07:23

geoand merged commit 4c0d835 into quarkusio:main May 2, 2025
59 checks passed

quarkus-bot bot added this to the 3.23 - main milestone May 2, 2025

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 2, 2025

michalvavrik deleted the feature/ws-next-micrometer-tests-and-spi branch May 2, 2025 11:15

WebSockets Next: use SPI to separate the Websockets extension from OpenTelemetry and Micrometer extensions #45522

WebSockets Next: use SPI to separate the Websockets extension from OpenTelemetry and Micrometer extensions #45522

Uh oh!

Conversation

michalvavrik commented Jan 13, 2025

Uh oh!

quarkus-bot bot commented Jan 13, 2025

Uh oh!

github-actions bot commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

mkouba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

gsmet commented Jan 28, 2025

Uh oh!

brunobat commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michalvavrik commented Jan 28, 2025

Uh oh!

michalvavrik commented Jan 28, 2025

Uh oh!

cescoffier commented Mar 31, 2025

Uh oh!

brunobat left a comment

Choose a reason for hiding this comment

Uh oh!

gsmet commented Apr 8, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

cescoffier left a comment

Choose a reason for hiding this comment

Uh oh!

michalvavrik commented Apr 13, 2025

Uh oh!

brunobat commented Apr 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

michalvavrik commented Apr 27, 2025

Uh oh!

michalvavrik commented Apr 27, 2025

Uh oh!

cescoffier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mkouba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

brunobat left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

michalvavrik commented May 2, 2025

Uh oh!

quarkus-bot bot commented May 2, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

quarkus-bot bot commented May 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

github-actions bot commented Jan 13, 2025 •

edited

Loading

brunobat commented Jan 28, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented May 2, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`