Make sure OidcRequestContextProperties are always modifiable #44936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Dec 5, 2024
This comment has been minimized.
This comment has been minimized.
|
Thanks @gastaldi, let me check that flaky test |
sberyozkin
force-pushed
the
mutable_oidc_request_context_props
branch
from
b72f144 to
201460b
Compare
|
@gastaldi The test failure is not related but I just added 2 extra secs there to minimize flakiness |
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #44203, which was not complete because
Map.ofcan be passed toOidcRequestContextPropertiesfrom different locations, the test in #44203 works because it just happens that a modifiable map is passed toOidcRequestContextPropertiesduring the token request, with test filters which modify properties being bound to the token request.Thanks to @sschellh for noticing it.