Skip to content

Switch back to Detached configuration for conditional dependencies in Gradle #42477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2024
Merged

Switch back to Detached configuration for conditional dependencies in Gradle #42477

merged 1 commit into from
Aug 12, 2024

Conversation

aloubyansky
Copy link
Member

Fix #41825

@aloubyansky aloubyansky marked this pull request as ready for review August 12, 2024 09:14
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Aug 12, 2024
@aloubyansky
Copy link
Member Author

@gsmet let's include this in 3.14. Thanks.

@gsmet
Copy link
Member

gsmet commented Aug 12, 2024

Should we backport it to 3.13.3 too?

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 12, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1e1e6e5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet mentioned this pull request Aug 12, 2024
Merged
@aloubyansky
Copy link
Member Author

I think our users would appreciate that

@aloubyansky aloubyansky merged commit a1b4e8a into quarkusio:main Aug 12, 2024
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 12, 2024
@gsmet gsmet modified the milestones: 3.14.0.CR1, 3.13.3 Aug 19, 2024
@kronst kronst mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

No one assigned

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle kind/bugfix

Projects

None yet

Milestone

3.13.3

Development

Successfully merging this pull request may close these issues.

Quarkus Gradle Plugin 3.12.1+ breaks composite builds

2 participants

@aloubyansky @gsmet