Upgrade to Hibernate Validator 9.0 #42292

marko-bekhta · 2024-08-02T10:17:12Z

Opening as a draft, as this is a Beta release only.

Fixes: constraint mappings specified in META-INF/validation.xml aren't applied #5531
Fixes: HV000151: A method overriding another method must not redefine the parameter constraint configuration #35144

marko-bekhta · 2024-09-05T11:25:53Z

The upgrade should address:
#5531
#35144

github-actions · 2024-09-05T12:00:31Z

🙈 The PR is closed and the preview is expired.

geoand · 2024-09-20T06:38:14Z

@marko-bekhta thanks for this!

Apart from the the PR needing to be rebased, is there anything more that needs to be done in order for it to be considered ready?

marko-bekhta · 2024-09-20T07:21:42Z

Hey @geoand 👋🏻 😃

From the Validator's perspective, there are no more updates to apply at the moment. As to marking it ready for a review ... there are probably a few things to consider:

This series of the Validator (9.0) targets Jakarta Validation 3.1, which is part of Jakarta EE 11. So it should probably be aligned with other EE specs getting into Quarkus, right?
There is still no final release of Expressly (expression language impl), which Validator depends on; hence, we haven't yet released the final Validator version.

geoand · 2024-09-20T07:43:49Z

I see, thanks for the update!

I'll let @gsmet comment further, since he is the SME on this :)

geoand · 2024-12-18T06:15:01Z

If we want this, it will need a rebase

gsmet · 2024-12-18T09:38:39Z

My take on this is that it's nice to have the PRs ready but I'd like to sync things a bit and preferably move everything we can to Jakarta EE 11 at the same time.

Let's keep this PR open (and updated when new releases come out) and we can decide later what to do with it.

marko-bekhta · 2024-12-18T09:43:20Z

Let's keep this PR open (and updated when new releases come out) and we can decide later what to do with it.

👍🏻 that makes sense 😃
btw here's a related ticket Yoann created for ORM/Reactive that would also be EE11-based: #45164

And as for the HV itself ... we still would need a final release of Expressly, but there's no news on when that could happen 😕

gsmet · 2025-04-25T12:21:54Z

@marko-bekhta I'm willing to open the gate for EE 11 integration now that ORM 7 is close to completion.

If you can revive this PR, I think we can get it in for 3.23.

marko-bekhta · 2025-04-25T12:53:49Z

rebased 😃🤞🏻
You'd probably want the final for Quarks, which, generally speaking, shouldn't be a problem. However, as for expressly ... it still only has the 6.0.0-M1 available and no idea when they'll release a final.

gsmet · 2025-04-25T12:59:25Z

So Jakarta 11 is still not released? We had some people pushing us to do the move as it was supposed to be released (at least the important part).

marko-bekhta · 2025-04-25T13:08:56Z

a jakartaee-bom final bom was publihsed on 2025-03-12 (https://central.sonatype.com/artifact/jakarta.platform/jakarta.jakartaee-bom/11.0.0)
and web-profile released March 30: https://projects.eclipse.org/projects/ee4j.jakartaee-platform/releases/web-profile-11
So I think in terms of specs it's all done, but as for the impls ....

geoand · 2025-05-14T16:33:39Z

Any update on this?

The reason I am asking is that I would like to have this so we can close our only bug left from 2019 😆

marko-bekhta · 2025-05-14T16:56:01Z

bug left from 2019

mmmm 2019 😃 😌 ☺️

Any update on this?

I'm ready to do a 9.0.0.Final even today 🙈 but the problem is still with the missing Expressly 6.0.0 Final 😕

https://jakarta.ee/specifications/expression-language/6.0/ suggests that Tomcat is a compatible EL implementation 🙈 but IDK if we'd want to switch from Expressly to Tomcat in Quarkus 🙈 (it's probably this one:https://central.sonatype.com/artifact/org.apache.tomcat/tomcat-jasper-el/overview)

geoand · 2025-05-14T17:11:59Z

I see, thanks!

gsmet · 2025-05-20T13:36:30Z

Let's wait for Expressly, we are in no hurry.

marko-bekhta · 2025-05-20T19:14:01Z

Let's wait for Expressly, we are in no hurry.

ha 😃 https://repo1.maven.org/maven2/org/glassfish/expressly/expressly/6.0.0/
That wasn't a long wait since this comment 😃 😏
I've rebased the PR and will mark it ready, but you decide when you want it in.

…mentation

geoand · 2025-05-21T13:05:03Z

I took the liberty to rebase the PR onto main to see if CI is in better shape

marko-bekhta · 2025-05-21T13:08:13Z

thanks 😃
also feel free to ping me if you need a rebase or something else to update 😃

geoand · 2025-05-21T13:09:02Z

👍🏽

quarkus-bot · 2025-05-21T13:43:21Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 37cf4cc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-05-21T16:04:46Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 37cf4cc.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 17			Logs	Raw logs	🔍
✔️	JVM Tests - JDK 21			Logs	Raw logs	🔍
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	JVM Integration Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✔️	JVM Integration Tests - JDK 17 Windows			Logs	Raw logs	🔍
✔️	JVM Integration Tests - JDK 21			Logs	Raw logs	🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/bom-descriptor-json devtools/cli extensions/agroal/deployment and 147 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.proxy.TrustedForwarderDnsResolveTest.testTrustedProxyResolved - History - More details - Source on GitHub

java.io.IOException: 
Error while binding on /127.0.0.1:53530
original message : Address already in use: bind
	at org.apache.mina.transport.socket.nio.NioSocketAcceptor.open(NioSocketAcceptor.java:238)
	at org.apache.mina.transport.socket.nio.NioSocketAcceptor.open(NioSocketAcceptor.java:51)
	at org.apache.mina.core.polling.AbstractPollingIoAcceptor.registerHandles(AbstractPollingIoAcceptor.java:585)
	at org.apache.mina.core.polling.AbstractPollingIoAcceptor.access$400(AbstractPollingIoAcceptor.java:71)
	at org.apache.mina.core.polling.AbstractPollingIoAcceptor$Acceptor.run(AbstractPollingIoAcceptor.java:459)

⚙️ JVM Integration Tests - JDK 17 #

- Failing: integration-tests/observability-lgtm

📦 integration-tests/observability-lgtm

✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on project quarkus-integration-test-observability-lgtm:

See /home/runner/_work/quarkus/quarkus/integration-tests/observability-lgtm/target/surefire-reports for the individual test results. See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. There was an error in the forked process

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/infinispan-cache/deployment

✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:435)

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

✖ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

Too many recursions, message not returned for id [966390518] - java.lang.RuntimeException

java.lang.RuntimeException: Too many recursions, message not returned for id [966390518]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:168)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:171)

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.LoggingResourceTest.testException - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.LoggingResourceTest was not fulfilled within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.it.opentelemetry.LoggingResourceTest.testException(LoggingResourceTest.java:113)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-validator Hibernate Validator labels Aug 2, 2024

marko-bekhta mentioned this pull request Aug 21, 2024

Normalize CDIWrappers to an interface that they implement for Validator #42654

Closed

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from b214566 to c303b6b Compare September 5, 2024 11:24

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from c303b6b to f91ddee Compare September 20, 2024 07:40

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from f91ddee to 324ad68 Compare December 16, 2024 09:47

marko-bekhta mentioned this pull request Dec 17, 2024

Upgrade to Hibernate ORM 7 #45164

Closed

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from 324ad68 to 7d3598c Compare December 18, 2024 07:30

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from 7d3598c to a77999d Compare February 6, 2025 15:40

quarkus-bot bot added the area/documentation label Feb 6, 2025

gsmet mentioned this pull request Mar 14, 2025

Jakarta EE 11 support #46827

Open

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from a77999d to 0a9dd22 Compare April 25, 2025 12:50

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from 0a9dd22 to 69359d2 Compare May 20, 2025 13:18

marko-bekhta force-pushed the dep/hibernate-validator-9-upgrade branch from 69359d2 to 9446252 Compare May 20, 2025 19:10

marko-bekhta marked this pull request as ready for review May 20, 2025 19:14

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label May 20, 2025

marko-bekhta added 4 commits May 21, 2025 16:04

Upgrade to Hibernate Validator 9.0

2c80968

Add a test for a bean where constraints are defined only in an XML

9b0fd8a

Add a test for a convert group on an interface with a generated imple…

7513799

…mentation

Adjust the note on constraint declaration in XML

37cf4cc

geoand force-pushed the dep/hibernate-validator-9-upgrade branch from 9446252 to 37cf4cc Compare May 21, 2025 13:04

gsmet approved these changes May 21, 2025

View reviewed changes

gsmet merged commit 211ae37 into quarkusio:main May 21, 2025
59 of 61 checks passed

quarkus-bot bot added this to the 3.24 - main milestone May 21, 2025

quarkus-bot bot added the kind/bugfix label May 21, 2025

gsmet added the release/noteworthy-feature label May 27, 2025

Upgrade to Hibernate Validator 9.0 #42292

Upgrade to Hibernate Validator 9.0 #42292

Uh oh!

Conversation

marko-bekhta commented Aug 2, 2024 • edited by geoand Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marko-bekhta commented Sep 5, 2024

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geoand commented Sep 20, 2024

Uh oh!

marko-bekhta commented Sep 20, 2024

Uh oh!

geoand commented Sep 20, 2024

Uh oh!

geoand commented Dec 18, 2024

Uh oh!

gsmet commented Dec 18, 2024

Uh oh!

marko-bekhta commented Dec 18, 2024

Uh oh!

gsmet commented Apr 25, 2025

Uh oh!

marko-bekhta commented Apr 25, 2025

Uh oh!

gsmet commented Apr 25, 2025

Uh oh!

marko-bekhta commented Apr 25, 2025

Uh oh!

geoand commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marko-bekhta commented May 14, 2025

Uh oh!

geoand commented May 14, 2025

Uh oh!

gsmet commented May 20, 2025

Uh oh!

marko-bekhta commented May 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

geoand commented May 21, 2025

Uh oh!

marko-bekhta commented May 21, 2025

Uh oh!

geoand commented May 21, 2025

Uh oh!

quarkus-bot bot commented May 21, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

quarkus-bot bot commented May 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ JVM Tests - JDK 17 Windows #

📦 extensions/vertx-http/deployment

⚙️ JVM Integration Tests - JDK 17 #

📦 integration-tests/observability-lgtm

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/infinispan-cache/deployment

⚙️ Maven Tests - JDK 17

📦 integration-tests/devmode

⚙️ JVM Integration Tests - JDK 17

📦 integration-tests/opentelemetry

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/opentelemetry

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

marko-bekhta commented Aug 2, 2024 •

edited by geoand

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

geoand commented May 14, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented May 21, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`