- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3k
 
Make URL inherit TestHTTPEndpoint from class level #35095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| 
           The test failures are definitely related  | 
    
| 
           That is correct. There was an scenario that I was considering in my tests but was not already supported in the code. I also managed to run the tests with  I'm only not sure about my last change, specially   | 
    
| 
           Can you squash the commits please?  | 
    
b614e33    to
    b61cee6      
    Compare
  
    | 
           Done  | 
    
| } | ||
| String val; | ||
| if (resource.ssl()) { | ||
| if (resource != null && resource.ssl()) { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the one I wasn't sure about.  If there is @TestHTTPEndpoint, but no @TestHTTPResource, then resource is null.
I kept it like that because @TestHTTPResource's SSL's default value is false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, let's see what see CI says
          Failing Jobs - Building b61cee6
 Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/opentelemetry 
📦 integration-tests/opentelemetry✖  ✖  ⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/opentelemetry 
📦 integration-tests/opentelemetry✖  ✖  ⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/vertx-http/deployment 
! Skipped: extensions/agroal/deployment extensions/avro/deployment extensions/cache/deployment and 333 more📦 extensions/vertx-http/deployment✖  ⚙️ JVM Tests - JDK 20 #- Failing: integration-tests/opentelemetry 
📦 integration-tests/opentelemetry✖  ✖   | 
    
| 
           Not sure what the timeout error might be about. Should I rebase it again?  | 
    
| 
           The test failures do seem to be related to the change - see the report  | 
    
I was unable to compile the project with VSCode (the contributing page doesn't talk much about it), but
./mvnw "-Dquickly"passed successfully.Functionality:
If a Test Class is annotated with
@TestHTTPEndpointthen all URL fields inherit it's configuration.If URL is also annotated, URL's annotation takes precedence.
Tests:
I couldn't find the tests for original functionality, so I included both (new and original).
I reused some resources/endpoints. Not sure if that's acceptable/expected or not.
Closes #34935