Make the Mailer extension trigger the SSL support #3377
Conversation
| == Using SSL with native executables | ||
|
|
||
| Note that if you enable SSL for the mailer and you want to build a native executable, you will need to enable the SSL support. | ||
| Please refer to the native-and-ssl-guide.html[Using SSL With Native Executables] guide for more information. |
There was a problem hiding this comment.
I think this is still interesting as you might have to bundle the SSL libraries in your Docker image for instance.
|
|
||
| Note that if you enable SSL for the mailer and you want to build a native executable, you will need to enable the SSL support. | ||
| Please refer to the native-and-ssl-guide.html[Using SSL With Native Executables] guide for more information. | ||
|
|
There was a problem hiding this comment.
Could you also update the list of extensions enabling SSL automatically here: https://quarkus.io/guides/native-and-ssl-guide ?
It's just after the sentence As SSL is ipso facto the standard nowadays, we decided to enable its support automatically for some of our extensions:.
I think we miss some of the recently added (Neo4j comes to mind). We should s/SmallRye REST client/REST client/ too. And maybe we should add the name of the extensions in parentheses (quarkus-mailer).
There was a problem hiding this comment.
Good catch. I’ll update that part.
machi1990
force-pushed
the
enable-ssl-support-for-mailer
branch
from
b062781 to
4007717
Compare
| ==== | ||
|
|
||
| === Working with containers | ||
|
|
There was a problem hiding this comment.
I don't think we want these changes, do we?
There was a problem hiding this comment.
Ooops, my IDE was not synced with recent changes. I'll revert this.
| When working with containers, the idea is to bundle both the SunEC library and the certificates in the container and to point your binary to them using the system properties mentioned above. | ||
|
|
||
| You can for example modify your `Dockerfile.native` as follows to copy the required files to your final image: | ||
| You can for example modify your `Dockerfile.native` as following to allow copying the required lib in your final image: |
There was a problem hiding this comment.
Looks like you reverted some changes I made recently.
There was a problem hiding this comment.
Good catch. Sorry for the noise. I'll rebase and apply the change I need to make.
| * the Agroal connection pooling extension (`quarkus-agroal`), | ||
| * the Jaeger extension (`quarkus-jaeger`), | ||
| * the mailer extension (`quarkus-mailer`) | ||
| * the Neo4j extension (`quarkus-neo4j`). |
There was a problem hiding this comment.
Neo4j was an example, there are a lot more missing. Just look for references to ExtensionSslNativeSupportBuildItem.
As for the Elasticsearch client extension, better name the Hibernate Search + Elasticsearch one because that's the one we want to advertise.
| * the REST client extension (`quarkus-rest-client`), | ||
| * the Agroal connection pooling extension (`quarkus-agroal`), | ||
| * the Jaeger extension (`quarkus-jaeger`), | ||
| * the mailer extension (`quarkus-mailer`) |
There was a problem hiding this comment.
| * the mailer extension (`quarkus-mailer`) | |
| * the Mailer extension (`quarkus-mailer`) |
machi1990
force-pushed
the
enable-ssl-support-for-mailer
branch
from
4007717 to
438897e
Compare
| * the Agroal connection pooling extension, | ||
| * the Jaeger extension. | ||
| * the Agroal connection pooling extension (`quarkus-agroal`), | ||
| * the DynamoDB extension (`quarkus-amazon-dynamodb`), |
There was a problem hiding this comment.
I think we should talk about Amazon DynamoDB
| * the Jaeger extension. | ||
| * the Agroal connection pooling extension (`quarkus-agroal`), | ||
| * the DynamoDB extension (`quarkus-amazon-dynamodb`), | ||
| * the Elasticsearch Rest client extension (`quarkus-elasticsearch-rest-client`), |
There was a problem hiding this comment.
As said in another comment, here I would advertise the Hibernate Search + Elasticsearch extension instead of the client.
For now, we don't really want the users to include this extension directly.
| ---- | ||
|
|
||
| == Using SSL with native executables | ||
|
|
gsmet
changed the title
machi1990
force-pushed
the
enable-ssl-support-for-mailer
branch
from
438897e to
4367824
Compare
gsmet
added
the
triage/waiting-for-ci
|
Merged, thanks! |
2 participants
Fixes #3221