-
Notifications
You must be signed in to change notification settings - Fork 3k
First shot at integrating mp-metrics. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No clue if the interceptors are intercepting.
| metrics.createRegistries(); | ||
| } | ||
|
|
||
| try (BytecodeRecorder recorder = processorContext.addDeploymentTask(RuntimePriority.WELD_DEPLOYMENT + 30 ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno, could this be moved to static instead of deployment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the answer is "yes"
| } | ||
|
|
||
| public void addInterceptor(SeContainerInitializer initialize, Class<?> interceptorClass) { | ||
| initialize.enableInterceptors(interceptorClass); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SeContainerInitializer.enableInterceptors() only enables the interceptors for the synthetic bean archive. MetricsInterceptor and friends are enabled globally (for the application) using @Priority - so there's no need to enable them locally. In fact, this enablement is just ignored.
|
Hm, so because the discovery is disabled completely the smallrye extension is not used and you're trying to simulate the functionality, right? Of course, you could use |
Make BeanContainer.RequestAction more generic
No clue if the interceptors are intercepting.