Skip to content

Kubernetes: Add default template.metadata in StatefulSet resource #27825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

Kubernetes: Add default template.metadata in StatefulSet resource #27825

merged 1 commit into from
Sep 9, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Sep 9, 2022

Fix #26581

@Sgitario
Copy link
Contributor Author

Sgitario commented Sep 9, 2022

I've also checked that for Deployment resources, the template labels are properly populated.

@Sgitario Sgitario mentioned this pull request Sep 9, 2022
Closed
geoand
geoand approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@geoand geoand merged commit cf0cbca into quarkusio:main Sep 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 9, 2022
@Sgitario Sgitario deleted the kubernetes_fix_stateful branch September 9, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoand geoand geoand approved these changes

+1 more reviewer

@manusa manusa manusa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/kubernetes

Projects

None yet

Milestone

2.13.0.CR1

Development

Successfully merging this pull request may close these issues.

[CI] - Kubernetes end-to-end testing

3 participants

@Sgitario @manusa @geoand