System property name change quarkus-project-discovery -> quarkus-ws-discovery #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Apr 4, 2019
|
What about quarkus-cp-cache? @gsmet |
|
Well, I don't like it either if it's your question :). I don't think it's a good idea to introduce obscure acronyms in exposed properties. |
|
It's not a big deal to me. So I will change them. |
* quarkus-project-discovery -> quarkus-workspace-discovery * quarkus-cp-cache -> quarkus-classpath-cache
aloubyansky
force-pushed
the
quarkus-ws-discovery
branch
from
6e209d3 to
7edcd8c
Compare
gsmet
approved these changes
Apr 4, 2019
|
Let's wait for CI and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change, it's very unlikely users have started using it and it didn't exist in the previous release.
I'll document the properties introduced in bootstrap after this has been merged.