ArC - fix handling of disposed parameter qualifiers

[mkouba]

• resolves NPE in io.quarkus:quarkus-maven-plugin:0.12.0:build #1839

[mkouba]

@hwellmann Could you pls try this patch with your application?

[hwellmann]

Testing with a local build of your branch, the original NPE no longer occurs, but now I'm getting a similar one related to producers:

Caused by: java.lang.NullPointerException
    at io.quarkus.arc.processor.Types.getTypeClosure (Types.java:245)
    at io.quarkus.arc.processor.Types.getTypeClosure (Types.java:160)
    at io.quarkus.arc.processor.Beans.createProducerMethod (Beans.java:118)
    at io.quarkus.arc.processor.BeanDeployment.findBeans (BeanDeployment.java:634)
    at io.quarkus.arc.processor.BeanDeployment.<init> (BeanDeployment.java:136)
    at io.quarkus.arc.processor.BeanProcessor.process (BeanProcessor.java:150)
    at io.quarkus.arc.deployment.ArcAnnotationProcessor.build (ArcAnnotationProcessor.java:259)
    at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:498)
    at io.quarkus.deployment.ExtensionLoader$1.execute (ExtensionLoader.java:506)
    at org.jboss.builder.BuildContext.run (BuildContext.java:413)
    at org.jboss.threads.ContextClassLoaderSavingRunnable.run (ContextClassLoaderSavingRunnable.java:35)
    at org.jboss.threads.EnhancedQueueExecutor.safeRun (EnhancedQueueExecutor.java:1998)
    at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask (EnhancedQueueExecutor.java:1525)
    at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1416)
    at java.lang.Thread.run (Thread.java:748)
    at org.jboss.threads.JBossThread.run (JBossThread.java:479)

[manovotn]

Looks good!

[mkouba]

@hwellmann Thanks. The other one is quite weird. Is your producer annotated with @Typed() (i.e. with no value)?

[hwellmann]

Almost: the class of the producer's return type is annotated @Typed() with no arguments.

(The producer method is org.apache.deltaspike.core.util.ProjectStageProducer.getProjectStage()).

[hwellmann]

Parameteter -> Parameter

[hwellmann]

Diposed -> Disposed

[mkouba]

@hwellmann Ok, I'll try to fix this case. But note that deltaspike will very likely not work on quarkus - it heavily relies on portable extensions that are not supported.

[hwellmann]

Yes, I know that DeltaSpike won't work. I'm converting an existing project, and the first shot was just to add quarkus-maven-plugin and run it. At least it seems to help discover some edge cases ;-)

[mkouba]

@hwellmann @manovotn Ok, one more fix added. If CI is green and you're satisfied we should merge this PR and eventually create a new issue (I do expect more corner cases like this ;-).

[hwellmann]

Test successful. The stack trace no longer occurs.

[mkouba]

@hwellmann Thanks!