Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 2, 2019

I changed the formatter to avoid this sort of mess: https://github.com/quarkusio/quarkus/pull/1778/files#diff-cf15f1a3d008af1e9ced9a328aa63978R21 or https://github.com/quarkusio/quarkus/pull/1815/files#diff-fc458120f0f357520a9b55e2058f22a8L10

Even if the diff for the formatter is huge, I imported the config, then changed the enum formatting, then exported the config.

I ran the formatter on the source and there are a few changes but all of them looks legit to me and most of them are enum-related.

@gsmet gsmet force-pushed the format-enum-one-per-line branch from 764a8dc to d00c533 Compare April 2, 2019 14:24
It should allow to better track changes.
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guillaume Smet: Could someone using IDEA check that they can import the new formatter config of this PR: https://github.com/quarkusio/quarkus/pull/1815 ?

Guillaume Smet: I had to change the formatting for enums as it led to really weird-looking code

David Lloyd: could the diff be made smaller by ordering the properties the same way they were ordered before?

David Lloyd: I guess they should have been alpha to begin with

Guillaume Smet: yeah, the order coming from Eclipse is apparently totally random :/

David Lloyd: how about one commit to sort the original alphabetically, and then another commit to add the changes?

David Lloyd: then we can at least see what changed

Guillaume Smet: I can try

@gsmet gsmet added this to the 0.13.0 milestone Apr 2, 2019
@gsmet gsmet force-pushed the format-enum-one-per-line branch from d00c533 to 374b1fc Compare April 2, 2019 15:09
@gsmet
Copy link
Member Author

gsmet commented Apr 2, 2019

@dmlloyd so it was even more painful as Eclipse apparently added a lot of new formatter properties (maybe Stuart used an old version of Eclipse when working on it).

I did it in 3 steps: reorder the existing file, import/export the existing file (+order), change the enum config.

@gsmet gsmet merged commit 0ab5510 into quarkusio:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants