IdGeneration strategies initialized as part of the pre-recorded Metadata #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem at all! |
gsmet
reviewed
Apr 2, 2019
| implements MutableIdentifierGeneratorFactory, Serializable, ServiceRegistryAwareService { | ||
|
|
||
| private final DefaultIdentifierGeneratorFactory original = new DefaultIdentifierGeneratorFactory(); | ||
| private final ConcurrentHashMap<String, Class<? extends IdentifierGenerator>> typeCache = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Just wondering if we should clear this cache at some point, considering we keep references to the classes? Or is it taken care of somehow?
There was a problem hiding this comment.
No we don't want to clear them as they are used by ORM at runtime:
- the instance is scoped for the specific SessionFactgory instance
- It will only contain references to Class instance of the few ID generators actually used (stuff which is going to be on the heap even if we don't refer to it)
|
@gsmet approved? would be good to have this in |
gsmet
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #1767 and fixes #1743
Many thanks to @geoand for giving it a shot. Sorry it wasn't as simple as I initially thought!