Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Apr 1, 2019

  • rename it to quarkus-bootstrap-maven-plugin
  • reformat pom.xml (in a separate commit)
  • move the descriptors to META-INF/ instead of having a quarkus/ directory at the root.

@gsmet gsmet force-pushed the rename-bootstrap-plugin branch from ae47664 to d38e411 Compare April 1, 2019 16:14
@gsmet gsmet requested a review from aloubyansky April 1, 2019 16:19
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing I remember we wanted to consider was to use io.quarkus as a groupId. We should probably discuss that. But that could be done in a separate PR. Thanks!

@gsmet
Copy link
Member Author

gsmet commented Apr 1, 2019

If it's an entirely independent project, I think it would make sense to have a separate groupId but, yes, better discuss it on the list. Just underline in the email that it is supposed to be an independent project.

@aloubyansky aloubyansky merged commit 35080e6 into quarkusio:master Apr 1, 2019
@gsmet gsmet added this to the 0.13.0 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants