Vert.x web - support RX routing context #1798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Apr 1, 2019
mkouba
commented
- resolves vert.x web extension does not support RX routing context #1589
- also validate method return type
johnaohara
requested changes
Apr 1, 2019
...ns/vertx-web/deployment/src/main/java/io/quarkus/vertx/web/deployment/VertxWebProcessor.java
Show resolved
Hide resolved
...ns/vertx-web/deployment/src/main/java/io/quarkus/vertx/web/deployment/VertxWebProcessor.java
Show resolved
Hide resolved
...ns/vertx-web/deployment/src/main/java/io/quarkus/vertx/web/deployment/VertxWebProcessor.java
Show resolved
Hide resolved
extensions/vertx-web/deployment/src/test/java/io/quarkus/vertx/web/SimpleRouteTest.java
Show resolved
Hide resolved
- resolves quarkusio#1589 - also validate method return type
|
@johnaohara comments addressed ;-) |
|
@mkouba great, thanks |
johnaohara
approved these changes
Apr 2, 2019
cescoffier
approved these changes
Apr 2, 2019
|
Waiting for CI |
|
@cescoffier |
|
Looks like some CI failure because the build actually passed, well except the windows machine that was "abandoned" (I have no idea what it means). |
|
Tried to re-run the windows build. |
|
The first Windows build was "abandoned", but the second build passed. The first Windows build appears to be stuck in an "In progress" state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.