Skip to content

Conversation

stuartwdouglas
Copy link
Collaborator

This allows for remote container based development using a websocket connection.

@stuartwdouglas
Copy link
Collaborator Author

This needs some tests and docs before it is properly ready to be merged, but just opened a PR here for testing.

* as indicated by the @author tags. See the copyright.txt file in the
* distribution for a full listing of individual contributors.
* This is free software; you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you seem to have a random variety of headers. In particular this one mentionging LGPL is probably not OK :)

I think would be best if you could delete them all?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this was from some old code I had lying around

Sanne
Sanne previously requested changes Mar 25, 2019
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the LGPL headers need to be removed.

Secondarily: should we wait for Alexey's big changes first?

This allows for remote container based development using a websocket connection.
@Sanne
Copy link
Member

Sanne commented Mar 26, 2019

This needs some tests and docs before it is properly ready to be merged, but just opened a PR here for testing.

@stuartwdouglas are you happy with "tests and docs" aspect?

Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I'd merge it but @stuartwdouglas seemed to prefer to hold until he had some more tests/docs?

@stuartwdouglas
Copy link
Collaborator Author

I added tests and docs yesterday, so it should be all good

@stuartwdouglas stuartwdouglas merged commit fe00f80 into quarkusio:master Mar 26, 2019
@gsmet gsmet added this to the 0.13.0 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants