-
Notifications
You must be signed in to change notification settings - Fork 3k
Add the remote-dev command #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This needs some tests and docs before it is properly ready to be merged, but just opened a PR here for testing. |
* as indicated by the @author tags. See the copyright.txt file in the | ||
* distribution for a full listing of individual contributors. | ||
* This is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU Lesser General Public License as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you seem to have a random variety of headers. In particular this one mentionging LGPL is probably not OK :)
I think would be best if you could delete them all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, this was from some old code I had lying around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the LGPL headers need to be removed.
Secondarily: should we wait for Alexey's big changes first?
This allows for remote container based development using a websocket connection.
358a357
to
087b16f
Compare
@stuartwdouglas are you happy with "tests and docs" aspect? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I'd merge it but @stuartwdouglas seemed to prefer to hold until he had some more tests/docs?
I added tests and docs yesterday, so it should be all good |
This allows for remote container based development using a websocket connection.