Search for a native image for gradle builds if the maven search fails #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can correctly run SubstrateTests with Gradle. - there is a difference between Gradle and Maven regarding tests however. Gradle will by default try to run everything it can in the
src/test/javafolder. The common way of splitting up integration tests in Gradle is to put the integration tests in a different folder, eg:src/integTest/java.In the current state (with this fix), if a user tries to run the quickstarts with gradle (with a correct build file) either the QuarkusTest or SubstrateTest will fail. Depending on what he have built. - just a fyi for further discussions :)