Skip to content

Conversation

cescoffier
Copy link
Member

We had the code but not the writeup. This PR provides the instructions to build the Kafka example yourself.

@cescoffier cescoffier added this to the 0.12.0 milestone Mar 19, 2019
@cescoffier cescoffier requested a review from gsmet March 19, 2019 17:02
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cescoffier interesting one! I added some comments inline.

-Dextensions="reactive-kafka,vert.x"
----

This command generates a Maven project, importing the Reactive Messaging and Kafka connector extensions. Eclipse Vert.x is also required as the Kafka connector relies on Vert.x.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't Vert.x be a dependency of the Kafka connector extension, then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some strange reason, it does not work when building the native image. It's a known bug, we need to have a look.

We need to configure Kafka connector. This is done in the `application.properties` file.
The keys are structured as follow:

`smallrye.messaging.[sink|source].{stream-name}.property=value`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will really need to talk about if we want to achieve consistency with every configuration setting being quarkus.<something>. Maybe it doesn't make sense for MP components, I don't know, but I thought it was the convention.

(General comment, don't change anything)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still in discussion for the spec, so likely be changed soon. But yes, the question is whether we want quarkus.. The implementation would support this (you just need to add a bean in the extension).

@gsmet
Copy link
Member

gsmet commented Mar 19, 2019

@cescoffier I added the noteworthy-feature tag as I think new guides should be highlighted in the releases.

@cescoffier cescoffier requested a review from gsmet March 20, 2019 07:19
@gsmet gsmet force-pushed the features/add-kafka-guide branch from 598b55f to 2be58fc Compare March 20, 2019 10:34
@gsmet gsmet merged commit 9dbe2d1 into quarkusio:master Mar 20, 2019
@cescoffier cescoffier deleted the features/add-kafka-guide branch January 21, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants