-
Notifications
You must be signed in to change notification settings - Fork 3k
Provide the Kafka quickstart guide #1579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cescoffier interesting one! I added some comments inline.
-Dextensions="reactive-kafka,vert.x" | ||
---- | ||
|
||
This command generates a Maven project, importing the Reactive Messaging and Kafka connector extensions. Eclipse Vert.x is also required as the Kafka connector relies on Vert.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't Vert.x be a dependency of the Kafka connector extension, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some strange reason, it does not work when building the native image. It's a known bug, we need to have a look.
We need to configure Kafka connector. This is done in the `application.properties` file. | ||
The keys are structured as follow: | ||
|
||
`smallrye.messaging.[sink|source].{stream-name}.property=value` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will really need to talk about if we want to achieve consistency with every configuration setting being quarkus.<something>
. Maybe it doesn't make sense for MP components, I don't know, but I thought it was the convention.
(General comment, don't change anything)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still in discussion for the spec, so likely be changed soon. But yes, the question is whether we want quarkus.
. The implementation would support this (you just need to add a bean in the extension).
@cescoffier I added the |
Replace the hardcoded version.
598b55f
to
2be58fc
Compare
We had the code but not the writeup. This PR provides the instructions to build the Kafka example yourself.