When starting native image, use argument for log file location #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like there is a formatting issue with |
|
my fault, forgot spaces (and run with -Pformat before i pushed) |
n1hility
reviewed
Mar 19, 2019
test-framework/common/src/main/java/io/quarkus/test/common/PropertyTestUtil.java
Outdated
Show resolved
Hide resolved
|
@stalep could you squash your commits, please? Let's avoid purely cosmetic commits. You agree it's a regression? I think we need to have that one in tomorrow's release. |
|
yes, i think its a regression. scott merged my previous pr for this before i had a chance to change it. - not scotts fault though, i just have to fix my regressions :) |
stalep
force-pushed
the
quarkus-log-file2
branch
from
32d1847 to
5e52532
Compare
cescoffier
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not make sense to use System.properties when creating a new process, added back the
quarkus.log.file.pathargument.